Fix a possible segfault when parsing JSON containing very large strings

Summary: Taken from Seldaek/jsonlint@a3844d4.

Test Plan: Ported the test case from Seldaek/jsonlint#25.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11323

Author: joshuaspence

.editorconfig

@@ -11,6 +11,9 @@ insert_final_newline = true
 trim_trailing_whitespace = false
 insert_final_newline = false
 
+[src/parser/__tests__/json/*.data]
+insert_final_newline = false
+
 [src/parser/__tests__/languageguesser/*]
 indent_style =
 

externals/jsonlint/src/Seld/JsonLint/Lexer.php

@@ -20,7 +20,7 @@ class JsonLintLexer
     private $rules = array(
         0 => '/^\s+/',
         1 => '/^-?([0-9]|[1-9][0-9]+)(\.[0-9]+)?([eE][+-]?[0-9]+)?\b/',
-        2 => '{^"(\\\\["bfnrt/\\\\]|\\\\u[a-fA-F0-9]{4}|[^\0-\x09\x0a-\x1f\\\\"])*"}',
+        2 => '{^"(?:\\\\["bfnrt/\\\\]|\\\\u[a-fA-F0-9]{4}|[^\0-\x09\x0a-\x1f\\\\"]+)*"}',
         3 => '/^\{/',
         4 => '/^\}/',
         5 => '/^\[/',

src/parser/__tests__/PhutilJSONParserTestCase.php

@@ -22,6 +22,15 @@ public function testValidJSON() {
       '{"test":"http:\/\/foo\\\\zomg"}'
         => array('test' => 'http://foo\\zomg'),
       '["http:\/\/foo\\\\zomg"]' => array('http://foo\\zomg'),
+      Filesystem::readFile(dirname(__FILE__).'/json/base64.json') => array(
+        'action' => 'candidate.create',
+        'actionId' => '80653a26cc46357ff79ff83b47e27c3cb7a668bd',
+        'params' => array(
+          'attachments' => array(
+            Filesystem::readFile(dirname(__FILE__).'/json/base64.data'),
+          ),
+        ),
+      ),
     );
 
     foreach ($tests as $input => $expect) {