Moved get and set actions to the separate classes

Author: idle-code

TreeRoot.py

@@ -15,8 +15,8 @@ def start(self):
         self._install_actions()
 
     def _install_actions(self):
-        self.install_action(ActionNode('get', BasicActions.get))
-        self.install_action(ActionNode('set', BasicActions.set))
+        self.install_action(GetAction())
+        self.install_action(SetAction())
         self.install_action(ListAction())
         self.install_action(ActionNode('exists', BasicActions.exists))
         self.install_action(ActionNode('create', BasicActions.create))

actions/BasicActions.py

@@ -1,5 +1,6 @@
 from ActionNode import *
 
+
 class BasicActions:
     @staticmethod
     def get(target: Node):
@@ -26,8 +27,24 @@ def remove(target: Node, name_to_remove: str):
         target.remove(name_to_remove)
 
 
+class GetAction(ActionNode):
+    def __init__(self):
+        super().__init__(path='get')
+
+    def __call__(self, target: Node):
+        return target.get()
+
+
+class SetAction(ActionNode):
+    def __init__(self):
+        super().__init__(path='set')
+
+    def __call__(self, target: Node, new_value):
+        target.set(new_value)
+
+
 class ListAction(ActionNode):
-    def __init__(self=None):
+    def __init__(self):
         super().__init__(path='list')
 
     def __call__(self, target: Node):

tests/action_tests/GetActionTests.py

@@ -0,0 +1,51 @@
+import unittest
+
+from Node import Node
+from NodePath import NodePath
+from TreeRoot import TreeRoot
+from actions.BasicActions import GetAction
+
+
+class GetActionTests(unittest.TestCase):
+    def setUp(self):
+        self.root = Node()
+        self.root.append(Node(123), 'integer')
+        self.root.append(Node('foobar'), 'string')
+        self.root.append(Node(), 'empty')
+
+        self.get = GetAction()
+
+    def test_get(self):
+        self.assertEqual(123, self.get(self.root['integer']))
+        self.assertEqual('foobar', self.get(self.root['string']))
+        self.assertEqual(None, self.get(self.root['empty']))
+
+    def test_get_any_arguments(self):
+        with self.assertRaises(TypeError):
+            self.get(self.root['empty'], 1 ,2 ,3)
+
+
+class GetActionNodeTests(unittest.TestCase):
+    def setUp(self):
+        self.root = TreeRoot()
+        self.root.create('.integer', 123)
+        self.root.create('.string', 'foobar')
+        self.root.create('.empty')
+
+    def test_get(self):
+        integer = self.root.execute('.integer', NodePath('get'))
+        self.assertEqual(123, integer)
+
+        string = self.root.execute('.string', NodePath('get'))
+        self.assertEqual('foobar', string)
+
+        empty = self.root.execute('.empty', NodePath('get'))
+        self.assertEqual(None, empty)
+
+    def test_get_any_arguments(self):
+        with self.assertRaises(TypeError):
+            self.root.execute('.', NodePath('get'), 3, 2, 1)
+
+
+if __name__ == '__main__':
+    unittest.main()

tests/action_tests/SetActionTests.py

@@ -0,0 +1,67 @@
+import unittest
+
+from Node import Node
+from NodePath import NodePath
+from TreeRoot import TreeRoot
+from actions.BasicActions import SetAction
+
+
+class SetActionTests(unittest.TestCase):
+    def setUp(self):
+        self.root = Node()
+        self.root.append(Node(123), 'integer')
+        self.root.append(Node('foobar'), 'string')
+        self.root.append(Node(), 'empty')
+
+        self.set = SetAction()
+
+    def test_set(self):
+        self.set(self.root['integer'], 321)
+        self.assertEqual(321, self.root['integer'].get())
+        self.set(self.root['string'], 'barfoo')
+        self.assertEqual('barfoo', self.root['string'].get())
+
+    def test_set_different_type(self):
+        with self.assertRaises(TypeError):
+            self.set(self.root['integer'], 'string')
+
+    def test_set_none(self):
+        # This behaviour is subject to change
+        with self.assertRaises(TypeError):
+            self.set(self.root['empty'], 23)
+
+    def test_set_too_many_arguments(self):
+        with self.assertRaises(TypeError):
+            self.set(self.root['integer'], 1, 2, 3)
+
+
+class SetActionNodeTests(unittest.TestCase):
+    def setUp(self):
+        self.root = TreeRoot()
+        self.root.create('.integer', 123)
+        self.root.create('.string', 'foobar')
+        self.root.create('.empty')
+
+    def test_set(self):
+        self.root.execute('.integer', NodePath('set'), 444)
+        self.assertEqual(444, self.root.get('.integer'))
+
+        self.root.execute('.string', NodePath('set'), 'barfoo')
+        self.assertEqual('barfoo', self.root.get('.string'))
+
+    def test_set_different_type(self):
+        with self.assertRaises(TypeError):
+            self.root.execute('.integer', NodePath('set'), 'string')
+
+    def test_set_none(self):
+        # This behaviour is subject to change
+        with self.assertRaises(TypeError):
+            self.root.execute('.empty', NodePath('set'), 444)
+
+    def test_set_any_arguments(self):
+        with self.assertRaises(TypeError):
+            self.root.execute('.integer', NodePath('set'), 3, 2, 1)
+
+
+if __name__ == '__main__':
+    unittest.main()