Integrate many pre-commit hooks

Author: idle-code

.coveragerc

@@ -9,4 +9,3 @@ exclude_lines =
 	if __name__ == .__main__.:
 	def __str__
 	def __repr__
-

.idea/ContextShell.iml

@@ -0,0 +1,38 @@
+exclude: '^\.idea/.*$'
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: master
+    hooks:
+      - id: check-executables-have-shebangs
+      - id: check-merge-conflict
+      - id: debug-statements
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: master
+    hooks:
+      - id: mypy
+        files: 'contextshell|tests'
+#  - repo: https://github.com/guykisel/prospector-mirror
+#    rev: master
+#    hooks:
+#      - id: prospector
+#        exclude: "tests"
+  - repo: https://github.com/asottile/pyupgrade
+    rev: master
+    hooks:
+      - id: pyupgrade
+        args:
+          - --py36-plus
+  - repo: https://github.com/doublify/pre-commit-isort
+    rev: master
+    hooks:
+      - id: isort
+  - repo: https://github.com/ambv/black
+    rev: master
+    hooks:
+      - id: black
+        exclude: "tests"
+        args:
+          - -l 100
+          - --py36

.idea/dictionaries/idlecode.xml

@@ -140,8 +140,10 @@ disable=print-statement,
         deprecated-sys-function,
         exception-escape,
         comprehension-escape,
-        C0111, # Missing docstrings # TODO: re-enable when interfaces are more stable
-        W0511 # fixme-like strings 
+        bad-continuation,
+        too-few-public-methods,  # TODO: re-enable when interfaces are more stable
+        C0111, # Missing docstrings  # TODO: re-enable when interfaces are more stable
+        W0511 # fixme-like strings
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

.idea/misc.xml

@@ -4,11 +4,13 @@ verify_ssl = true
 name = "pypi"
 
 [packages]
+
+[dev-packages]
+mypy = "*"
 coverage = "==5.0a1"
 pylint = "*"
 git-pylint-commit-hook = "*"
-
-[dev-packages]
+pre-commit = "*"
 
 [requires]
 python_version = "3.7"

.idea/modules.xml

@@ -16,4 +16,3 @@ if [[ $TESTS_PASSED -eq 0 ]];
 then
 	coverage report -m
 fi
-

.idea/scopes/Sources.xml

@@ -1,18 +1,16 @@
 from abc import ABC, abstractmethod
 from collections import OrderedDict
-from typing import Union, Any, Tuple
-from typing import Callable
-from typing import Optional, List, Dict
-from .path import NodePath
+from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
+from .path import NodePath
 
-ArgumentValue = Any
+ArgumentValue = Any  # pylint: disable=invalid-name
 ActionArgsPack = Dict[Union[NodePath, int], ArgumentValue]
 PositionalArguments = List[ArgumentValue]
 KeywordArguments = Dict[str, ArgumentValue]
 
 
-class Action(ABC):
+class Action(ABC):  # pylint: disable=too-few-public-methods
     def __init__(self, name: NodePath) -> None:
         assert isinstance(name, NodePath)
         assert name.is_relative
@@ -25,6 +23,7 @@ def invoke(self, target: NodePath, action: NodePath, arguments: ActionArgsPack):
 
 class CallableAction(Action):
     """Action with implementation based on python callables"""
+
     def __init__(self, implementation: Callable, name: NodePath) -> None:
         super().__init__(name)
         self.implementation = implementation
@@ -37,8 +36,8 @@ def invoke(self, target: NodePath, action: NodePath, arguments: ActionArgsPack):
 
 def action_from_function(function_to_wrap: Callable) -> Action:
     action_name: str = function_to_wrap.__name__
-    if action_name.endswith('_action'):
-        action_name = action_name[:-len('_action')]
+    if action_name.endswith("_action"):
+        action_name = action_name[: -len("_action")]
     action_path = NodePath.from_python_name(action_name)
     return CallableAction(function_to_wrap, action_path)
 
@@ -60,19 +59,21 @@ def execute(self, target: NodePath, action_name: NodePath, args: ActionArgsPack
             args = OrderedDict()
         action_impl = self.find_action(target, action_name)
         if action_impl is None:
-            raise NameError("Could not find action named '{}'".format(action_name))
+            raise NameError(f"Could not find action named '{action_name}'")
         return action_impl.invoke(target, action_name, args)
 
 
-def unpack_argument_tree(action_args: ActionArgsPack) -> Tuple[PositionalArguments, KeywordArguments]:
+def unpack_argument_tree(
+    action_args: ActionArgsPack
+) -> Tuple[PositionalArguments, KeywordArguments]:
     args: Dict[int, ArgumentValue] = dict()
     kwargs: KeywordArguments = OrderedDict()
     for key, value in action_args.items():
         if isinstance(key, int):
             args[key] = value
         else:
             kwargs[key.to_python_name()] = value
-    assert not args or max(args.keys()) < len(args)+len(kwargs)
+    assert not args or max(args.keys()) < len(args) + len(kwargs)
     positional_args = [a[1] for a in sorted(args.items())]
     return positional_args, kwargs
 
@@ -88,13 +89,14 @@ def pack_argument_tree(*args: PositionalArguments, **kwargs: KeywordArguments) -
 
 def parse_argument_tree(raw_arguments: List[str]) -> ActionArgsPack:
     from contextshell.command import convert_token_type
+
     pack_list: List[Tuple[Union[NodePath, int], ArgumentValue]] = []
     for i, arg in enumerate(raw_arguments):
-        if isinstance(arg, str) and '=' in arg:
-            key, value = arg.split('=')
+        if isinstance(arg, str) and "=" in arg:
+            key, value = arg.split("=")
             key_path = NodePath.from_python_name(key)
             if key_path.is_absolute:
-                raise ValueError("Named argument path must be relative - {}".format(key_path))
+                raise ValueError(f"Named argument path must be relative - {key_path}")
             typed_value = convert_token_type(value)
             pack_list.append((key_path, typed_value))
         else:
@@ -104,6 +106,7 @@ def parse_argument_tree(raw_arguments: List[str]) -> ActionArgsPack:
 
 class BuiltinExecutor(ActionExecutor):
     """Manages built-in, global action registry"""
+
     def __init__(self):
         super().__init__()
         self.builtin_actions: Dict[NodePath, Action] = {}