Added create and remove action classes

Author: idle-code

TreeRoot.py

@@ -19,8 +19,8 @@ def _install_actions(self):
         self.install_action(SetAction())
         self.install_action(ListAction())
         self.install_action(ExistsAction())
-        self.install_action(ActionNode('create', BasicActions.create))
-        self.install_action(ActionNode('remove', BasicActions.remove))
+        self.install_action(CreateAction())
+        self.install_action(RemoveAction())
 
     def install_action(self, action_node: ActionNode):
         if action_node is None:

actions/BasicActions.py

@@ -50,6 +50,23 @@ def __init__(self):
     def __call__(self, target: Node, node_name: str) -> bool:
         return target.contains(node_name)
 
+
+class CreateAction(ActionNode):
+    def __init__(self):
+        super().__init__(path='create')
+
+    def __call__(self, target: Node, name: str, value=None):
+        target.append(Node(value), name)
+
+
+class RemoveAction(ActionNode):
+    def __init__(self):
+        super().__init__(path='remove')
+
+    def __call__(self, target: Node, node_name: str):
+        target.remove(node_name)
+
+
 class ListAction(ActionNode):
     def __init__(self):
         super().__init__(path='list')

tests/action_tests/CreateActionTests.py

@@ -0,0 +1,46 @@
+import unittest
+
+from Node import Node
+from NodePath import NodePath
+from actions.BasicActions import CreateAction
+
+
+class CreateActionTests(unittest.TestCase):
+    def setUp(self):
+        self.root = Node()
+        self.root.append(Node(123), 'existing')
+
+        self.create = CreateAction()
+
+    def test_action_name(self):
+        self.assertEqual(NodePath('create'), self.create.path)
+
+    def test_default_value(self):
+        self.assertFalse(self.root.contains('default'))
+        self.create(self.root, 'default')
+        self.assertTrue(self.root.contains('default'))
+        self.assertIsNone(self.root['default'].get())
+
+    def test_with_value(self):
+        self.assertFalse(self.root.contains('value'))
+        self.create(self.root, 'value', 258)
+        self.assertTrue(self.root.contains('value'))
+        self.assertEqual(258, self.root['value'].get())
+
+    def test_existing(self):
+        self.assertTrue(self.root.contains('existing'))
+        with self.assertRaises(NameError):
+            self.create(self.root, 'existing')
+        with self.assertRaises(NameError):
+            self.create(self.root, 'existing', 'value')
+
+    def test_surplus_arguments(self):
+        with self.assertRaises(TypeError):
+            self.create(self.root, 'surplus', 'value', 'value2')
+
+    def test_no_arguments(self):
+        with self.assertRaises(TypeError):
+            self.create(self.root)
+
+if __name__ == '__main__':
+    unittest.main()

tests/action_tests/RemoveActionTests.py

@@ -0,0 +1,38 @@
+import unittest
+
+from Node import Node
+from NodePath import NodePath
+from actions.BasicActions import RemoveAction
+
+
+class RemoveActionTests(unittest.TestCase):
+    def setUp(self):
+        self.root = Node()
+        self.root.append(Node(123), 'existing')
+
+        self.remove = RemoveAction()
+
+    def test_action_name(self):
+        self.assertEqual(NodePath('remove'), self.remove.path)
+
+    def test_existing(self):
+        self.assertTrue(self.root.contains('existing'))
+        self.remove(self.root, 'existing')
+        self.assertFalse(self.root.contains('existing'))
+
+    def test_nonexistent(self):
+        self.assertFalse(self.root.contains('unknown'))
+        with self.assertRaises(NameError):
+            self.remove(self.root, 'unknown')
+
+    def test_surplus_arguments(self):
+        with self.assertRaises(TypeError):
+            self.remove(self.root, 'existing', 'name')
+
+    def test_no_argument(self):
+        with self.assertRaises(TypeError):
+            self.remove(self.root)
+
+
+if __name__ == '__main__':
+    unittest.main()