test: improve no-input mode test coverage (from PR ankitpokhrel#905)

Author: Ismar Iljazovic

internal/cmd/issue/edit/edit.go

@@ -101,7 +101,7 @@ func edit(cmd *cobra.Command, args []string) {
 
 	// Validate that at least one field was provided in no-input mode
 	if cmdutil.IsNoInputMode() {
-		if hasNoChanges(params, originalBody) {
+		if params.hasNoChanges() {
 			cmdutil.Failed("No editable fields provided. Use flags like -s, -b, -l, -C, -y, etc. to specify changes")
 		}
 	}
@@ -253,8 +253,8 @@ func handleUserAssign(project, key, assignee string, client *jira.Client) {
 	}
 }
 
-// hasNoChanges checks if any editable fields were provided in the params.
-func hasNoChanges(params *editParams, originalBody string) bool {
+// hasNoChanges checks if any editable fields were provided.
+func (params *editParams) hasNoChanges() bool {
 	return params.summary == "" &&
 		params.body == "" &&
 		params.priority == "" &&

internal/cmdutil/utils_test.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"github.com/mitchellh/go-homedir"
+	"github.com/spf13/viper"
 	"github.com/stretchr/testify/assert"
 
 	"github.com/ankitpokhrel/jira-cli/pkg/jira"
@@ -264,3 +265,144 @@ func TestGetSubtaskHandle(t *testing.T) {
 		})
 	}
 }
+
+func TestIsNoInputMode(t *testing.T) {
+	cases := []struct {
+		name     string
+		setup    func()
+		expected bool
+	}{
+		{
+			name: "returns false when no_input is not set",
+			setup: func() {
+				viper.Reset()
+			},
+			expected: false,
+		},
+		{
+			name: "returns true when no_input is set to true",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", true)
+			},
+			expected: true,
+		},
+		{
+			name: "returns false when no_input is set to false",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", false)
+			},
+			expected: false,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup()
+			assert.Equal(t, tc.expected, IsNoInputMode())
+		})
+	}
+}
+
+func TestShouldPrompt(t *testing.T) {
+	cases := []struct {
+		name          string
+		localNoInput  bool
+		globalNoInput bool
+		expected      bool
+	}{
+		{
+			name:          "should prompt when both local and global are false",
+			localNoInput:  false,
+			globalNoInput: false,
+			expected:      true,
+		},
+		{
+			name:          "should not prompt when local is true and global is false",
+			localNoInput:  true,
+			globalNoInput: false,
+			expected:      false,
+		},
+		{
+			name:          "should not prompt when local is false and global is true",
+			localNoInput:  false,
+			globalNoInput: true,
+			expected:      false,
+		},
+		{
+			name:          "should not prompt when both local and global are true",
+			localNoInput:  true,
+			globalNoInput: true,
+			expected:      false,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			viper.Reset()
+			if tc.globalNoInput {
+				viper.Set("no_input", true)
+			}
+
+			assert.Equal(t, tc.expected, ShouldPrompt(tc.localNoInput))
+		})
+	}
+}
+
+func TestNoInputConfigurationMethods(t *testing.T) {
+	cases := []struct {
+		name     string
+		setup    func(t *testing.T)
+		expected bool
+	}{
+		{
+			name: "reads no_input from viper.Set (config file simulation)",
+			setup: func(t *testing.T) {
+				viper.Reset()
+				viper.Set("no_input", true)
+			},
+			expected: true,
+		},
+		{
+			name: "reads no_input from environment variable",
+			setup: func(t *testing.T) {
+				viper.Reset()
+				viper.AutomaticEnv()
+				viper.SetEnvPrefix("jira")
+				t.Setenv("JIRA_NO_INPUT", "true")
+			},
+			expected: true,
+		},
+		{
+			name: "environment variable false is respected",
+			setup: func(t *testing.T) {
+				viper.Reset()
+				viper.AutomaticEnv()
+				viper.SetEnvPrefix("jira")
+				t.Setenv("JIRA_NO_INPUT", "false")
+			},
+			expected: false,
+		},
+		{
+			name: "prefers viper.Set over unset environment variable",
+			setup: func(t *testing.T) {
+				viper.Reset()
+				viper.AutomaticEnv()
+				viper.SetEnvPrefix("jira")
+				t.Setenv("JIRA_NO_INPUT", "")
+				viper.Set("no_input", true)
+			},
+			expected: true,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup(t)
+
+			result := IsNoInputMode()
+			assert.Equal(t, tc.expected, result)
+		})
+	}
+}

internal/config/generator_test.go

@@ -5,6 +5,7 @@ import (
 	"path/filepath"
 	"testing"
 
+	"github.com/spf13/viper"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -69,3 +70,89 @@ func TestCreate(t *testing.T) {
 	assert.NoError(t, os.Remove(file+".bkp"))
 	assert.NoError(t, os.Remove(filepath.Dir(file)))
 }
+
+func TestShallOverwrite(t *testing.T) {
+	cases := []struct {
+		name     string
+		setup    func()
+		expected bool
+	}{
+		{
+			name: "returns false when no_input mode is enabled",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", true)
+			},
+			expected: false,
+		},
+		{
+			name: "returns false when no_input mode is disabled or unset",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", false)
+			},
+			expected: false,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup()
+			defer viper.Reset()
+
+			result := shallOverwrite()
+			assert.Equal(t, tc.expected, result)
+		})
+	}
+}
+
+func TestConfigureInstallationTypeNoInput(t *testing.T) {
+	cases := []struct {
+		name             string
+		setup            func()
+		expectError      bool
+		expectedErrorMsg string
+	}{
+		{
+			name: "returns error when no_input mode is enabled and installation type not provided",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", true)
+			},
+			expectError:      true,
+			expectedErrorMsg: "installation type required in non-interactive mode",
+		},
+		{
+			name: "succeeds when installation type is provided in no_input mode",
+			setup: func() {
+				viper.Reset()
+				viper.Set("no_input", true)
+			},
+			expectError: false,
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			tc.setup()
+			defer viper.Reset()
+
+			cfg := &JiraCLIConfig{
+				Installation: "cloud",
+			}
+			if tc.expectError {
+				cfg.Installation = ""
+			}
+
+			gen := NewJiraCLIConfigGenerator(cfg)
+			err := gen.configureInstallationType()
+
+			if tc.expectError {
+				assert.Error(t, err)
+				assert.Contains(t, err.Error(), tc.expectedErrorMsg)
+			} else {
+				assert.NoError(t, err)
+			}
+		})
+	}
+}