Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline GCDs #252

Closed
mlincett opened this issue Dec 6, 2023 · 4 comments · Fixed by #258
Closed

Update baseline GCDs #252

mlincett opened this issue Dec 6, 2023 · 4 comments · Fixed by #258
Assignees
Labels
prod concern a problem with running at scale

Comments

@mlincett
Copy link
Collaborator

mlincett commented Dec 6, 2023

With 2023 run start we need to update the baseline GCDs. Baseline GCDs are fetched from convey in the generation of the base IceTray container. Hence the base IceTray container should be updated (*).

There seems to be no easy way for a Skymap Scanner developer to see:

  • whether a new IceTray container has been produced;
  • whether such container includes the required GCD (at least without trying to run the code once).

Can we rebase Skymap Scanner on a newer IceTray including the latest GCD?

(*) this workflow is far from optimal because the container content is determined by when the container is generated rather than by the Dockerfile content.

Please note that as I have already observed in https://github.com/icecube/realtime/issues/8 a quick solution would be to mirror the baseline GCDs to prod-exe.

@mlincett mlincett assigned mlincett, dsschult and ric-evans and unassigned mlincett Dec 6, 2023
@mlincett mlincett added the prod concern a problem with running at scale label Dec 6, 2023
@dsschult
Copy link
Member

dsschult commented Dec 6, 2023

Would it be better to stop doing the baseline GCDs in the icetray image and do them in the scanner image instead?

We've had this PR lingering for a while: WIPACrepo/docker-icecube-icetray#10

@mlincett
Copy link
Collaborator Author

mlincett commented Dec 6, 2023

Would it be better to stop doing the baseline GCDs in the icetray image and do them in the scanner image instead?

We've had this PR lingering for a while: WIPACrepo/docker-icecube-icetray#10

This could indeed be the best option.

@dsschult
Copy link
Member

dsschult commented Dec 6, 2023

@mlincett ok, I've merged that upstream PR. Could you change the skymap scanner Dockerfiles to grab the baseline GCDs from http://prod-exe.icecube.wisc.edu/baseline_gcds/ ?

@ric-evans
Copy link
Member

This will be versioned along with the image, so I'm good with any needed changes. I'd only be concerned if we're grabbing the data at runtime without any versioning, like checksums (see #166)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prod concern a problem with running at scale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants