-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poster fallback quality #28
Comments
@guilhermeleite-hotmart Could you please provide some links that doesn't have maxresdefault or sddefault in order to test a patch? Thanks! |
Sure thing. Here's an example of a video that doens't have maxresdefault but has hqdefault thumbnail. |
I think this issue could be a little easier, but as turns out, is a little more complex:
The purpose of this lib is always trying to be as fast and as little resource wise on requests. I'll have to think a little more on that but in the meanwhile if have any kind of ideas, please let me know. |
Thanks for analyzing the issue and going through all the work to get back to me. |
@ibrahimcesar Wouldn't it be possible to only use |
Problem
If maxresdefault or sddefault poster quality doesn`t exist the video gets no thumbnail.
Suggestion
Add fallback poster quality if the originally selected one is not available.
If the api call return a 404 the component could try again using the fallback quality.
The text was updated successfully, but these errors were encountered: