Skip to content

PLDM : Support to set expected PFW splash screen name #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaypadath opened this issue Jan 19, 2023 · 2 comments
Closed

PLDM : Support to set expected PFW splash screen name #3616

jaypadath opened this issue Jan 19, 2023 · 2 comments
Assignees
@lxwinspur
Labels
enhancement New feature or request ReadyForDev Stories ready for development work

Comments

@jaypadath
Copy link

This requirement is to set PFW splash screen to "Inspur Power Systems" or what ever the value customer decides instead of OEM blank.

Its basically a JSON change from BMC PLDM side.

Summarise the changes:

  1. We need to create a new JSON file at https://github.com/ibm-openbmc/pldm/tree/1050/oem/ibm/configurations/fru folder ie Motherboard_UTIL.json
  2. Add the UTIL records RT,F5,F6 to the JSON lookup and pldm will automatically read them and dynamically put those keyword contents in the PLDM FRU record table. For reference one can look at https://github.com/ibm-openbmc/pldm/blob/1020/oem/ibm/configurations/fru/Motherboard_DINF.json JSON file in the fru folder to figure out how to write these lookups.
    Note : Inventory support for the UTIL keywords F5 and F6 are already available. F5 and keywords will be read by Hostboot and update the attribute in HB-HDAT and pass it to hypervisor.
@jaypadath jaypadath added enhancement New feature or request ReadyForDev Stories ready for development work labels Jan 19, 2023
@jaypadath jaypadath mentioned this issue Jan 20, 2023
Closed
lxwinspur added a commit to lxwinspur/pldm that referenced this issue Jan 29, 2023
@lxwinspur
oem-ibm: FRU: Add UTIL entry
52718d5 
Add UTIL that has RT,F5,F6 entry to existing FRU configuration.
Resolves: ibm-openbmc/dev#3616

Tested: use pldmtool GetFRURecordTableMetadata cmd to verify the
output.

Signed-off-by: George Liu <[email protected]>
@lxwinspur lxwinspur mentioned this issue Jan 29, 2023
Closed
lxwinspur added a commit to lxwinspur/pldm that referenced this issue Jan 29, 2023
@lxwinspur
oem-ibm: FRU: Add UTIL entry
8c314c4 
Add UTIL that has RT,F5,F6 entry to existing FRU configuration.

Resolves: ibm-openbmc/dev#3616

Tested: use pldmtool GetFRURecordTableMetadata cmd to verify the
output.

Signed-off-by: George Liu <[email protected]>
@lxwinspur
Copy link

Review by: ibm-openbmc/pldm#350

lxwinspur added a commit to lxwinspur/pldm that referenced this issue Feb 17, 2023
@lxwinspur
oem-ibm: FRU: Add UTIL entry
0220011 
Add UTIL that has RT,F5,F6 entry to existing FRU configuration.

Resolves: ibm-openbmc/dev#3616

Tested: use pldmtool GetFRURecordTableMetadata cmd to verify the
output.

Signed-off-by: George Liu <[email protected]>
@jaypadath jaypadath mentioned this issue Jun 9, 2023
Merged
@lxwinspur
Copy link

@jaypadath
Could you close this issue?

rfrandse pushed a commit to rfrandse/pldm-1 that referenced this issue Jun 15, 2023
@jaypadath @rfrandse
oem-ibm: Support new UTIL keywords (ibm-openbmc#419)
66ebbeb 
This commit adds new UTIL record keywords RT, F5 and F6 under the
motherboard. F5 and F6 keywords are used to fill up the desired
host splash screen name displayed at the host console. The RT
keyword is used to hold the record name.

Resolves: ibm-openbmc/dev#3616

Tested: Verified that the name filled up through the F5 and F6
keywords are displayed at the host splash screen

Change-Id: I26f1c03db3e9f6a5b8cdc435d9e80d7c92563e16

Signed-off-by: Jayashankar Padath <[email protected]>
rfrandse added a commit to ibm-openbmc/pldm that referenced this issue Jun 16, 2023
@rfrandse @jaypadath
oem-ibm: Support new UTIL keywords (#419) (#422)
22099fd 
This commit adds new UTIL record keywords RT, F5 and F6 under the
motherboard. F5 and F6 keywords are used to fill up the desired
host splash screen name displayed at the host console. The RT
keyword is used to hold the record name.

Resolves: ibm-openbmc/dev#3616

Tested: Verified that the name filled up through the F5 and F6
keywords are displayed at the host splash screen

Change-Id: I26f1c03db3e9f6a5b8cdc435d9e80d7c92563e16

Signed-off-by: Jayashankar Padath <[email protected]>
Co-authored-by: Jayashankar Padath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lxwinspur lxwinspur

Labels
enhancement New feature or request ReadyForDev Stories ready for development work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaypadath @lxwinspur