feat(consider): Make isinstance(ibis.Deferred, ibis.Value) return true

[NickCrews]

Is your feature request related to a problem?

I have several util functions that I want to make polymorphic between ibis and vanilla python types:

def odds_to_prob(odds):
    normal = odds / (1 + odds)
    if isinstance(odds, (Deferred, ir.NumericValue)):
        return ibis.ifelse(odds.isinf(), 1.0, normal)
    else:
        return 1 if odds == float("inf") else normal

def round_to(nums: ir.NumericValue | Deferred | int | float, n: int) -> ir.IntegerValue:
    """Round to the nearest n, eg 5.

    eg with n=5:
    0 -> 0
    1 -> 0
    2 -> 0
    3 -> 5
    4 -> 5
    5 -> 5
    """
    if not isinstance(n, int):
        raise TypeError(f"n must be int, not {type(n)}")
    if isinstance(nums, (ir.NumericValue, Deferred)):
        return (nums / n).round().cast(int) * n
    else:
        return round(nums / n) * n

The first time I implemented these, I forgot to include the Deferred in the instance check, and that led to errors. Really what I am trying to test for is "is this an ibis thing that I can call ibis APIs on?" IDK, it might be a nice to help users avoid footguns like I ran into. On the other hand, maybe I should be forced to be explicit here.

I thought I would throw this up for discussion.

What is the motivation behind your request?

No response

Describe the solution you'd like

Make isinstance(ibis.Deferred, ir.Value) return True

What version of ibis are you running?

main

What backend(s) are you using, if any?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[cpcloud]

@NickCrews I think this is out of scope for Ibis. Deferred and Value are quite different and need to be handled separately.