Skip to content

Commit b32138f

Browse files
authored
Enhance preview comment (#2769)
1 parent 76d181c commit b32138f

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

.github/workflows/preview_comment.yaml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,24 @@ jobs:
3333
md_change_list=$(git diff --name-only HEAD "origin/$GITHUB_BASE_REF" -- docs/ | grep -E "^docs\/.*\.md$" | sed -E "s|^docs/(.*)\.md$|- [docs/\1.md](${build_url}\1/)|")
3434
par_change_list='';
3535
for par_file in $(git diff --diff-filter=A --name-only "origin/$GITHUB_BASE_REF" HEAD -- docs/api/php_api/php_api_reference/ | grep -E '^docs\/.*\.html$'); do
36-
fqcn=$(grep -o 'data-copy-value=".*">Copy FQCN' $par_file | sed 's|E|§E§|' | sed -E 's|data-copy-value="(.*)">.*|\1|' | sed 's|\\|\\\\|g')
36+
fqcn=$(grep -o 'data-copy-value=".*">Copy FQCN' $par_file | sed -E 's|data-copy-value="(.*)">.*|\1|' | sed 's|\\|\\\\|g')
3737
link=$(echo $par_file | sed -E "s|^docs/(.*\.html)$|- [\`${fqcn}\`](${build_url}\1)|")
3838
par_change_list=$(echo -e "$par_change_list\n$link")
3939
done
40-
par_change_list=$(echo "$par_change_list" | sed '1d' | sed 's|§E§|\\E|g')
40+
par_change_list=$(echo "$par_change_list" | sed '1d' | sort -t '`' -k 2,2)
4141
change_count=$(( $(echo "$md_change_list" | wc -l) + $(echo "$par_change_list" | wc -l) ))
4242
43-
if [[ -z "$md_change_list$par_change_list" ]] ; then
43+
echo -e "Markdown files:\n$md_change_list\n\nPHP API Ref.:\n$par_change_list" | perl -p -e 's/\e/\\E/g'
44+
45+
if [[ $change_count -gt $file_limit ]]; then
46+
par_change_list=$(echo "$par_change_list" | grep -v namespaces)
47+
change_count=$(( $(echo "$md_change_list" | wc -l) + $(echo "$par_change_list" | wc -l) ))
48+
fi
49+
50+
if [[ -z "$md_change_list$par_change_list" ]]; then
4451
comment="Preview of modified files: no change to preview."
45-
elif [[ $change_count -gt $file_limit ]] ; then
46-
comment="Preview of modified files: Too many files modified in a single PR, preview link list is skipped. ($change_count files &gth; $file_limit)"
52+
elif [[ $change_count -gt $file_limit ]]; then
53+
comment="Preview of modified files: Too many files modified in a single PR, preview link list is skipped. ($change_count files > $file_limit)"
4754
else
4855
comment="# Preview of modified files"
4956
if [[ -n "$md_change_list" ]]; then
@@ -54,7 +61,7 @@ jobs:
5461
fi
5562
fi
5663
57-
echo -e "$comment" > comment.md
64+
echo -e "$comment" | perl -p -e 's/\e/\\E/g' > comment.md
5865
5966
- name: Find comment
6067
id: find-comment

0 commit comments

Comments
 (0)