Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it shouldnt ask in a notification if the info has already being submited #1573

Open
2 tasks done
voidplayer opened this issue Nov 8, 2022 · 9 comments
Open
2 tasks done

Comments

@voidplayer
Copy link

Pre-submission checklist

  • I am submitting a bug report, not a feature request.
  • I have searched for similar issues, but did not find any matches.

Description

Even if the info is already entered, the notification with the reminder asking you will pop up at the designed time

Steps to reproduce

  • Create a habit where you have to enter a number and add a notification with a date
  • fill it for the day manually in the app
  • time for the notification will come and ask for it again
@kamil-cy
Copy link

I can confirm this also for Yes or No habits. If for example I have a habit Go to sleep earlier (at least two hours before midnight, but at 21:45 I mark this habit with No, because I have to finish my work and I know that it will takes me at least three hours, then the reminder pops up at 22:00 and still asks about the habit.

I can confirm this in versions 2.1.0 and 2.1.1 (latest), previous minor version 2.0.3 is working fine. Apps are from F-droid.

@KraXen72
Copy link

aditionally, i think it should still fire if you have not compelted the goal yet for value habits:
let's say i have a habit "coding", i set minimum 30min, and enter 20min in the app, => notification should still come, once it's above 30min, notification should no longer come.

@kamil-cy
Copy link

In my humble opinion this should be available as a checkbox in options/preferences globally in the app or maybe even globally and per habit. It would be great to have this possibility to set this in your own way.

@exanrauzer
Copy link

exanrauzer commented Feb 10, 2023

Agree with the main issue. But I would like to extend it:

The question if its done or its not makes me fuzzy. How could I have the habit done if I set a reminder for the habit to do it?? I never know what to do with this reminder. I would like to be alerted only, and be able to snooze it maybe, not to check-mark NOW. This questions is just incoherent with the app usage.

I think I am not the only one who fills the marks in the app once a day - at the evening, or the morning day after.

@nvllz
Copy link

nvllz commented Mar 20, 2023

Would it really be that hard to implement? A simple check before the notification is shown. I personally have faced this problem several times and I like your ideas. But the project seems to be not so maintained, as many things have been marked as not planned lately.

I especially like this checkbox thing, which could allow you to display a notification if the current value is below the minimum measurable value for a habit, called 'target'. So if the value is less than we expect, we will always get a notification at the set time. Either if it's 0 or 9.9 out of the expected 10. Once it is equal to or greater than the target value, there is no need to do any notification of the habit.

@exanrauzer you should be able to interact with the notification directly from the notification drawer. When you expand it, you should see corresponding buttons, and there you can find "Later" as an option. You can snooze the notification for a fixed delay or even display it at the specified time. I think the app is more of a habit tracker than just a reminder to do something. You can easily see what and how often you've done in the past days and see the habit score, and that's the biggest advantage of this app. But yeah... you can easily postpone the notification if you haven't done the thing yet. Hope you can find it too!

@nvllz
Copy link

nvllz commented Apr 8, 2023

If someone can tell me where to find the current value of a habit for today, I am willing to try to fix a bug myself. It should be easy to check if the habit has been updated today. You can manually mark the habit as incomplete by tapping the marker and clicking 'x', so the default value in the db must be something like '?' or null. To fix the bug, we just need to check if the value of the habit has changed before sending a notification. If it's a numeric value, we also need to check if it's higher or lower than the target value. If it's lower or unchanged, we send the notification as we do now.

Any ideas @iSoron, @hiqua?

@Mrnofish
Copy link

The notification should definitely not fire for a 'binary' (or boolean) habit once it's already been marked.

@nvllz

As noted by @kamil-cy:

I can confirm this in versions 2.1.0 and 2.1.1 (latest), previous minor version 2.0.3 is working fine. Apps are from F-droid.

The issue was not present in an older version. That could be a good lead about where to start.

@Yyuzu
Copy link

Yyuzu commented Sep 6, 2024

Would be nice indeed to be able to choose globally if we want entered habits to show up at the reminder time or not.
This is related #1546

Thank you!

@KyleSCraig
Copy link

@nvllz I know your comment was 2 years ago and the chances you're still interested are low, but there is isCompletedToday() and isEnteredToday() within core.models.Habit.

I think the desired behaviour needs to be defined though. I would just use isEnteredToday() personally but I don't use Numerical habits. And then there are some people who would enter only once a day and others who might keep incrementing it. Maybe even some people doing both depending on the habit.

Obviously if it has ? then show the notification. But when else?
When you have an X and you don't use the ? Setting vs when you have an X and you don't use a new setting specifically for this.
When you have an entered number but are below the target?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants