Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSP V1 format - missing function byte in response #10667

Open
JimB40 opened this issue Feb 2, 2025 · 3 comments
Open

Fix MSP V1 format - missing function byte in response #10667

JimB40 opened this issue Feb 2, 2025 · 3 comments
Labels

Comments

@JimB40
Copy link

JimB40 commented Feb 2, 2025

Tested on INAV 8.0.0

Current Behavior

Current MSP V1 has bug and doesn't adhere to MSP V1 spec.
https://github.com/iNavFlight/inav/wiki/MSP-V2#legacy-and-compatibility

function byte is not send after payload size

Image

This leads to numerous errors as we doesn't know if response coming is for actual request sent.
That leads to wrong data parsing.

Expected behavior

function byte should be sent after payload size and before actual payload bytes

@DzikuVx
Copy link
Member

DzikuVx commented Feb 3, 2025

What exactly are we looking at? According to a MSPV1 frame outgoing from FC should begin with $M> that converts to HEX 24 4D 3E and I don't see this sequence anywhere. Is this even MSP frame?

@DzikuVx DzikuVx added the Support label Feb 3, 2025
@JimB40
Copy link
Author

JimB40 commented Feb 3, 2025

MSP V1 over telemetry. CRSF frame where '$M>' are stripped.
So first 3 bytes in this dump are CRSF specyfic.
4th is MSP packet length.
5th should be MSP function (missing)
Then actual MSP payload goes.

@DzikuVx
Copy link
Member

DzikuVx commented Feb 3, 2025

@JimB40 here is potential fix #10671 could you please test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants