Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful blockage with lion’s shield against the dagger of draining causes it to trigger #385

Open
SplendidFault opened this issue May 31, 2015 · 4 comments
Assignees

Comments

@SplendidFault
Copy link

As the title suggests, the issue occurs when you successfully block an attacked by the rogue which is wielding the dagger of draining. I am not a programmer; therefore I could not pin down the issue in the code.

@mciul mciul added this to the Kerkerkruip 10 milestone Jun 1, 2015
@mciul
Copy link
Contributor

mciul commented Jun 1, 2015

A test should be added for this, in the "weapon aftereffects" set. I would like to nominate Victor to write that test, because I am at a point where I need to stop working on Kerkerkruip.

Victor - If you have looked at Automated Testing before, you will see that I've changed it a lot. I wrote a bunch of documentation for the new version which is basically finished but could use some formatting. But hopefully between reading that and looking at the code in Test Sets, it should be pretty straightforward to write this test. Feel free to contact me - I'd be happy to answer questions but I need to stay away from coding for my sanity's sake! :)

Also, if this is an imposition, I don't mind at all if you change or remove the assignee!

@curiousdannii
Copy link
Member

@mciul I hope that you will be able to come back soon to work on non-test related stuff!

@mciul
Copy link
Contributor

mciul commented Jun 2, 2015

Thanks, Dannii, but I think it will be a while. Every time I start working on something I get distracted by testing!

VictorGijsbers added a commit that referenced this issue Jun 8, 2016
Otherwise it can interfere with other aftereffects rules. Fixes #385.
@VictorGijsbers
Copy link
Member

Fixed the bug, rescheduling the test for Kerkerkruip 11.

@VictorGijsbers VictorGijsbers reopened this Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants