Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration with xdpw #26

Closed
columbarius opened this issue Feb 20, 2023 · 9 comments
Closed

Collaboration with xdpw #26

columbarius opened this issue Feb 20, 2023 · 9 comments

Comments

@columbarius
Copy link
Contributor

Hi, I'm one of the xdpw developers and started implementing the parts required for session restore and different capture targets. My next goals would be to push those into the chooser part such that users could interact with them.

Would there be interest to collaborate on this task?

Note: tried to join your discord server, but it requires phone validation.

@vaxerski
Copy link
Member

Note: tried to join your discord server, but it requires phone validation.

image

Would there be interest to collaborate on this task?

What do you mean by "collaborate"? I maintain -hyprland because hyprland-protocols

@columbarius
Copy link
Contributor Author

What I mean is that I'm interested in sharing the PipeWire and chooser specific parts of the portal implementation as much as possible, also easing in up/downstreaming of patches.

Would you be interested in reviewing and/or giving feedback on the capture_target and an improved chooser design (using json to communicate) and maybe adapting your chooser, such that it could work with xdpw as well? I'd continue to work on them tomorrow and could link those MRs here.

@vaxerski
Copy link
Member

Hyprland's QT chooser has nothing that would not work with xdpw. Obviously though, sharing windows would not be possible.

Unless you mean making the output whatever xdpw accepts, in which case it's not possible without modifications on the xdpw side.

Would you be interested in reviewing and/or giving feedback on the capture_target and an improved chooser design (using json to communicate)

I am not sure I understand what that entails. You want me to review your PRs to xdpw? I mean sure, I can. I guess.

and maybe adapting your chooser, such that it could work with xdpw as well? I'd continue to work on them tomorrow and could link those MRs here.

If you mean making the hyprland chooser use json as output, yeah, sure, that's not a biggie.

@mesmerx
Copy link

mesmerx commented Feb 21, 2023

i am working with the same feature @columbarius you are already in discord?
i get the session restore to work with both window and output, but i need to refactor to work with tiles and not only ids for windows to keep the share working even if the window is closed, if you wanna we can work togther

@mesmerx
Copy link

mesmerx commented Feb 21, 2023

i am translating your pr to this portal ( and you did a great job i need to say)

@columbarius
Copy link
Contributor Author

If you mean making the hyprland chooser use json as output, yeah, sure, that's not a biggie.

Great! I've updated emersion/xdg-desktop-portal-wlr#228.
Please take a look at chooser-protocol.json

@columbarius
Copy link
Contributor Author

i am working with the same feature @columbarius you are already in discord?

Yes, but without phone verification I can't write anything there.

i get the session restore to work with both window and output, but i need to refactor to work with tiles and not only ids for windows to keep the share working even if the window is closed, if you wanna we can work togther

Great!, I'd like to.

@vaxerski
Copy link
Member

Yes, but without phone verification I can't write anything there

you can, it's clearly stated in #rules to dm me on discord in case you can't/don't want to verify your phone number.

@vaxerski
Copy link
Member

I think this can be closed as this is no longer a fork

@vaxerski vaxerski closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants