Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: app-store: surface errors to GUI #592

Open
nick1udwig opened this issue Nov 1, 2024 · 3 comments
Open

feature: app-store: surface errors to GUI #592

nick1udwig opened this issue Nov 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@nick1udwig
Copy link
Member

nick1udwig commented Nov 1, 2024

Is your feature request related to a problem? Please describe.
When errors occur, user is not informed on GUI, e.g.:
https://github.com/kinode-dao/kinode/blob/281c481377e36764dde7d1e25cc0980ab63cc369/kinode/packages/app_store/downloads/src/lib.rs#L136-L143

Describe the solution you'd like
We need to inform the user an error has occurred. There are errors of two classes:

  1. Should never happen; these should tell user to inform us
  2. Can be remedied with user action (e.g., imagine a node goes down just as a user clicks to download an app from it). Should be user-facing: what happened and what user can do to try to fix it
@nick1udwig nick1udwig added the enhancement New feature or request label Nov 1, 2024
@nick1udwig
Copy link
Member Author

FYI @bitful-pannul

@nick1udwig
Copy link
Member Author

We need this before v0.10.0 is merged to main. We can use the difference between old & new nodes (app_store -> app-store) to test

@nick1udwig
Copy link
Member Author

@bitful-pannul does #599 resolve this issue or is there more work to be done here? Ideally any error that is encountered can be surfaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant