Skip to content

Commit 9932276

Browse files
committed
Helm chart should use same package repo as image, but use different tag
1 parent 2bdd15e commit 9932276

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.github/workflows/publish.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Install Go
3535
uses: actions/setup-go@v5
3636
with:
37-
go-version: 1.22
37+
go-version: 1.23
3838
check-latest: true
3939
- name: Build Installer
4040
run: make build-installer IMG=ghcr.io/hyperspike/valkey-operator:${{ github.ref_name }}
@@ -60,7 +60,7 @@ jobs:
6060
- name: Install Go
6161
uses: actions/setup-go@v5
6262
with:
63-
go-version: 1.22
63+
go-version: 1.23
6464
check-latest: true
6565
- name: Log in to the Container registry
6666
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@ go.work
3333
blank.yaml
3434
cilium/
3535
manager
36-
valkey-operator-chart/
37-
valkey-operator-chart-*.tgz
36+
valkey-operator/
37+
valkey-operator-*-chart.tgz

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -200,15 +200,15 @@ HELM_VERSION ?= v3.15.4
200200
GOSEC_VERSION ?= v2.20.0
201201

202202
helm-gen: manifests kustomize helmify ## Generate Helm chart from Kustomize manifests
203-
$Q$(KUSTOMIZE) build config/default | $(HELMIFY) -crd-dir valkey-operator-chart
204-
$Qsed s@\\\(app.kubernetes.io/name\\\)@\'\\\1\'@ -i valkey-operator-chart/templates/deployment.yaml
205-
$Qsed s@\\\(app.kubernetes.io/instance\\\)@\'\\\1\'@ -i valkey-operator-chart/templates/deployment.yaml
203+
$Q$(KUSTOMIZE) build config/default | $(HELMIFY) -crd-dir valkey-operator
204+
$Qsed s@\\\(app.kubernetes.io/name\\\)@\'\\\1\'@ -i valkey-operator/templates/deployment.yaml
205+
$Qsed s@\\\(app.kubernetes.io/instance\\\)@\'\\\1\'@ -i valkey-operator/templates/deployment.yaml
206206

207207
helm-package: helm-gen helm ## Package Helm chart
208-
$Q$(HELM) package valkey-operator-chart --app-version $(VERSION) --version $(VERSION)
208+
$Q$(HELM) package valkey-operator --app-version $(VERSION) --version $(VERSION)-chart
209209

210210
helm-publish: helm-package ## Publish Helm chart
211-
$Q$(HELM) push valkey-operator-chart-$(VERSION).tgz oci://ghcr.io/hyperspike
211+
$Q$(HELM) push valkey-operator-$(VERSION)-chart.tgz oci://ghcr.io/hyperspike
212212

213213
.PHONY: minikube tunnel registry-proxy prometheus-proxy
214214
minikube: ## Spool up a local minikube cluster for development

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ curl -sL https://github.com/hyperspike/valkey-operator/releases/download/$LATEST
5151

5252
```sh
5353
LATEST=$(curl -s https://api.github.com/repos/hyperspike/valkey-operator/releases/latest | jq -cr .tag_name)
54-
helm install valkey-operator-chart --namespace valkey-operator-system --create-namespace oci://ghcr.io/hyperspike/valkey-operator-chart --version $LATEST
54+
helm install valkey-operator --namespace valkey-operator-system --create-namespace oci://ghcr.io/hyperspike/valkey-operator --version $LATEST-chart
5555
```
5656

5757
### Verifying the container image

valkey.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ metadata:
88
spec:
99
nodes: 1
1010
volumePermissions: true
11-
prometheus: false
11+
prometheus: true
1212
tls: true
1313
certIssuer: selfsigned
1414
prometheusLabels:
15-
prometheus: "1"
15+
prometheus: prometheus

0 commit comments

Comments
 (0)