Merge pull request #108 from hyperspike/replicas

dmolik · web-flow · commit 4aee7f09cc59 · 2024-11-18T12:37:31.000-05:00
fix: fix replicas calculation in update code
diff --git a/internal/controller/valkey_controller.go b/internal/controller/valkey_controller.go
@@ -1543,7 +1543,8 @@ export VALKEY_CLUSTER_ANNOUNCE_HOSTNAME="${POD_NAME}.%s"
 	}
 
 	if *sts.Spec.Replicas != valkey.Spec.Nodes {
-		sts.Spec.Replicas = &valkey.Spec.Nodes
+		replicas := valkey.Spec.Nodes * (valkey.Spec.Replicas + 1)
+		sts.Spec.Replicas = &replicas
 		sts.Spec.Template.Spec.Containers[0].Env[1].Value = getNodeNames(valkey)
 		if err := r.Update(ctx, sts); err != nil {
 			logger.Error(err, "failed to update statefulset", "valkey", valkey.Name, "namespace", valkey.Namespace)

Original file line number	Diff line number	Diff line change
`@@ -1543,7 +1543,8 @@ export VALKEY_CLUSTER_ANNOUNCE_HOSTNAME="${POD_NAME}.%s"`
`1543`	`1543`	`}`
`1544`	`1544`
`1545`	`1545`	`if *sts.Spec.Replicas != valkey.Spec.Nodes {`
`1546`		`- sts.Spec.Replicas = &valkey.Spec.Nodes`
	`1546`	`+ replicas := valkey.Spec.Nodes * (valkey.Spec.Replicas + 1)`
	`1547`	`+ sts.Spec.Replicas = &replicas`
`1547`	`1548`	`sts.Spec.Template.Spec.Containers[0].Env[1].Value = getNodeNames(valkey)`
`1548`	`1549`	`if err := r.Update(ctx, sts); err != nil {`
`1549`	`1550`	`logger.Error(err, "failed to update statefulset", "valkey", valkey.Name, "namespace", valkey.Namespace)`