fix PID and process leak

Author: antonysouthworth-halter

Dockerfile.valkey

@@ -23,6 +23,7 @@ FROM alpine:3.21.3 AS valkey
 RUN apk add --no-cache \
 	openssl=3.3.3-r0 \
 	ca-certificates=20241121-r1 \
+	coreutils=9.5-r2 \
 	&& addgroup -S valkey -g 1009 \
 	&& adduser -S -G valkey valkey -u 1009 \
 	&& mkdir /etc/valkey \

internal/controller/scripts/ping_liveness_local.sh

@@ -2,7 +2,7 @@
 set -e
 if [ ! -z "$VALKEY_PASSWORD" ]; then export REDISCLI_AUTH=$VALKEY_PASSWORD; fi;
 response=$(
-  timeout -s 15 $1 \
+  timeout --foreground -s 15 $1 \
   valkey-cli \
     -h localhost \
     -p $VALKEY_PORT_NUMBER \

internal/controller/scripts/ping_liveness_local_tls.sh

@@ -4,7 +4,7 @@ set -e
 if [ ! -z "$VALKEY_PASSWORD" ]; then export REDISCLI_AUTH=$VALKEY_PASSWORD; fi;
 
 	response=$(
-	timeout -s 15 $1 \
+	timeout --foreground -s 15 $1 \
 	valkey-cli \
 		-h localhost \
 		-p $VALKEY_TLS_PORT_NUMBER \

internal/controller/scripts/ping_readiness_local.sh

@@ -4,7 +4,7 @@ set -e
 VALKEY_STATUS_FILE=/tmp/.valkey_cluster_check
 if [ ! -z "$VALKEY_PASSWORD" ]; then export REDISCLI_AUTH=$VALKEY_PASSWORD; fi;
 response=$(
-  timeout -s 15 $1 \
+  timeout --foreground -s 15 $1 \
   valkey-cli \
     -h localhost \
     -p $VALKEY_PORT_NUMBER \
@@ -21,7 +21,7 @@ fi
 nodes=$(echo $VALKEY_NODES | wc -w)
 if [ ! -f "$VALKEY_STATUS_FILE" ] && [ "$nodes" != "1" ]; then
   response=$(
-    timeout -s 15 $1 \
+    timeout --foreground -s 15 $1 \
     valkey-cli \
       -h localhost \
       -p $VALKEY_PORT_NUMBER \

internal/controller/scripts/ping_readiness_local_tls.sh

@@ -5,7 +5,7 @@ VALKEY_STATUS_FILE=/tmp/.valkey_cluster_check
 if [ ! -z "$VALKEY_PASSWORD" ]; then export REDISCLI_AUTH=$VALKEY_PASSWORD; fi;
 
 	response=$(
-	timeout -s 15 $1 \
+	timeout --foreground -s 15 $1 \
 	valkey-cli \
 		-h localhost \
 		-p $VALKEY_TLS_PORT_NUMBER \
@@ -28,7 +28,7 @@ fi
 count=$(echo $VALKEY_NODES | wc -w)
 if [ ! -f "$VALKEY_STATUS_FILE" ] && [ "$count" != "1" ]; then
 	response=$(
-		timeout -s 15 $1 \
+		timeout --foreground -s 15 $1 \
 		valkey-cli \
 			-h localhost \
 			-p $VALKEY_TLS_PORT_NUMBER \