Skip to content

Commit d85287b

Browse files
authored
fix(Test): improve the params in BenchmarkDbGrowth (#1967)
It seems some parameter settings have been changed in the past. As a result, some tests (at least one) lose the ability to test what they want to test. For `BenchmarkDbGrowth`, current default value of `ValueThreshold` makes no vlog will be created and current default value of `MemTableSize` makes no memtable will be flushed which means no compaction and thus no vlog gc will be performed. ## Solution Setting `ValueThreshold` be 1024 and `MemTableSize` be 1MB in this case seems to be fine. Signed-off-by: SpadeA-Tang <[email protected]>
1 parent 8671f9d commit d85287b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

db_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,8 @@ func BenchmarkDbGrowth(b *testing.B) {
466466
opts.NumVersionsToKeep = 1
467467
opts.NumLevelZeroTables = 1
468468
opts.NumLevelZeroTablesStall = 2
469+
opts.ValueThreshold = 1024
470+
opts.MemTableSize = 1 << 20
469471
db, err := Open(opts)
470472
require.NoError(b, err)
471473
for numWrites := 0; numWrites < maxWrites; numWrites++ {

0 commit comments

Comments
 (0)