don't panic if binding and no ephemeral ids were given

Hayim.Shaul@ibm.com · Hayim.Shaul@ibm.com · commit e6a5d2341960 · 2025-09-03T09:02:34.000-05:00
Signed-off-by: Hayim.Shaul@ibm.com &lt;hayimsha@he4cloud1.sl.cloud9.ibm.com&gt;
diff --git a/platform/view/services/storage/driver/sql/postgres/binding.go b/platform/view/services/storage/driver/sql/postgres/binding.go
@@ -42,7 +42,7 @@ func newBindingStore(readDB, writeDB *sql.DB, table string) *BindingStore {
 
 func (db *BindingStore) PutBindings(ctx context.Context, longTerm view.Identity, ephemeral ...view.Identity) error {
 	if len(ephemeral) == 0 {
-		return errors.New("no ephemeral identities provided")
+		return nil
 	}
 
 	logger.DebugfContext(ctx, "put bindings for %d ephemeral(s) with long term [%s]", len(ephemeral), longTerm.UniqueID())
diff --git a/platform/view/services/storage/driver/sql/sqlite/binding.go b/platform/view/services/storage/driver/sql/sqlite/binding.go
@@ -76,7 +76,7 @@ func newBindingStore(readDB *sql.DB, writeDB common2.WriteDB, table string) *Bin
 
 func (db *BindingStore) PutBindings(ctx context.Context, longTerm view.Identity, ephemeral ...view.Identity) error {
 	if len(ephemeral) == 0 {
-		return errors.New("no ephemeral identities provided")
+		return nil
 	}
 
 	logger.DebugfContext(ctx, "put bindings for %d ephemeral(s) with long term [%s]", len(ephemeral), longTerm.UniqueID())

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func newBindingStore(readDB, writeDB sql.DB, table string) BindingStore {`
`42`	`42`
`43`	`43`	`func (db *BindingStore) PutBindings(ctx context.Context, longTerm view.Identity, ephemeral ...view.Identity) error {`
`44`	`44`	`if len(ephemeral) == 0 {`
`45`		`- return errors.New("no ephemeral identities provided")`
	`45`	`+ return nil`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`logger.DebugfContext(ctx, "put bindings for %d ephemeral(s) with long term [%s]", len(ephemeral), longTerm.UniqueID())`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ func newBindingStore(readDB sql.DB, writeDB common2.WriteDB, table string) Bin`
`76`	`76`
`77`	`77`	`func (db *BindingStore) PutBindings(ctx context.Context, longTerm view.Identity, ephemeral ...view.Identity) error {`
`78`	`78`	`if len(ephemeral) == 0 {`
`79`		`- return errors.New("no ephemeral identities provided")`
	`79`	`+ return nil`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`logger.DebugfContext(ctx, "put bindings for %d ephemeral(s) with long term [%s]", len(ephemeral), longTerm.UniqueID())`