-
Notifications
You must be signed in to change notification settings - Fork 232
feat: add Warden Protocol #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cb45094 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a minor changeset with yarn changeset add
📝 WalkthroughWalkthroughAdds Warden Protocol chain configuration: two new YAML files under Changes
Sequence Diagram(s)No sequence diagrams — changes are static configuration additions without control-flow or behavioral modifications. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
chains/wardenprotocol/metadata.yaml (2)
20-23: Token naming polishUsually name is human-friendly (“Warden”) and symbol is ticker (“WARD”). If the chain’s native coin is indeed named “WARD”, all good—otherwise consider:
nativeToken: decimals: 18 - name: WARD + name: Warden symbol: WARD
25-27: Add a backup RPC for resilienceConsider a second RPC (different provider/host) to avoid single-point outages.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
chains/wardenprotocol/logo.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
chains/wardenprotocol/addresses.yaml(1 hunks)chains/wardenprotocol/metadata.yaml(1 hunks)
🔇 Additional comments (5)
chains/wardenprotocol/metadata.yaml (4)
8-10: Double-check block paramsConfirm 2s block time and 7 confirmations with reorgPeriod 5 reflect actual chain conditions; these feed UX and safety margins in downstream apps.
14-19: Uniqueness verified for chainId/domainId and name
No conflicts found for 8765 or “wardenprotocol”.
2-6: Verify correct Blockscout API endpointNeither https://explorer.wardenprotocol.org/api nor https://blocksync.wardenprotocol.org/api returned a valid Blockscout response—please double-check which host actually serves the API (and update apiUrl and family accordingly).
16-16: CoinGecko slug confirmed
All set—‘warden-2’ is the official slug per CoinGecko and Warden Protocol docs.chains/wardenprotocol/addresses.yaml (1)
1-14: Aye, that rogue backslash before “!=” is trippin’ Python. Remove it so the check readslen(addr) != 42, then rerun the checksum script. Once you’ve got the output, ping me back.
|
@paulbalaji could we get a review, please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just needs a yarn lint:fix
|
@paulbalaji done 🫡 |
Description
Add Warden Protocol chain
Backward compatibility
Yes
Testing
Yes, everything has been tested.
Summary by CodeRabbit