remove debug setting (#30)

sanzoghenzo · web-flow · commit e0599b45374c · 2023-08-23T20:44:26.000+02:00
* remove debug setting closes #29 * build: update manifest with new version
diff --git a/README.md b/README.md
@@ -14,7 +14,6 @@ For example playing a video should enable screen capture, if you pause the video
 - Setup wizard with Hyperion Server detection (zero configuration)
 - Token Authorization (optional)
 - Languages: English, German, Spanish, French, Polish, Hungarian
-- Debug option with notifications
 - Execute from settings dialog: Hyperion Server detection
 
 ### Installation
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,14 +14,7 @@ warn_unused_configs = true
 warn_unused_ignores = true
 
 [[tool.mypy.overrides]]
-module = [
-    "androguard.*",
-    "uplink",
-    "requests.*",
-    "authlib.*",
-    "pytest",
-    "pyaxmlparser.*"
-]
+module = ["requests.*"]
 ignore_missing_imports = true
 
 [tool.ruff]
diff --git a/script.service.hyperion-control/addon.xml b/script.service.hyperion-control/addon.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <addon id="script.service.hyperion-control" name="Hyperion Control" version="20.0.0" provider-name="hyperion-project">
   <requires>
-	<import addon="xbmc.addon"  version="20.0.0"/>
+	<import addon="xbmc.addon"  version="20.0.1"/>
     <import addon="xbmc.python" version="3.0.1"/>
     <import addon="script.module.requests" version="2.3.0"/>
   </requires>
@@ -17,6 +17,9 @@
     <website>https://hyperion-project.org/forum</website>
     <source>https://github.com/hyperion-project/hyperion.control</source>
     <news>
+      20.0.1
+      - Removed redundant debug setting
+
       20.0.0
       - Kodi 20 (Nexus) support
       - Multi instance handling
diff --git a/script.service.hyperion-control/resources/language/resource.language.de_de/strings.po b/script.service.hyperion-control/resources/language/resource.language.de_de/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Deaktiviere Hyperion beim Beenden"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Aktiviere Debugging"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/language/resource.language.en_gb/strings.po b/script.service.hyperion-control/resources/language/resource.language.en_gb/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Disable Hyperion on shutdown"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Enable Debug"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/language/resource.language.es_es/strings.po b/script.service.hyperion-control/resources/language/resource.language.es_es/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Deshabilitar Hyperion al apagar"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Habilitar la Depuración"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/language/resource.language.fr_fr/strings.po b/script.service.hyperion-control/resources/language/resource.language.fr_fr/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Désactiver Hyperion à l'extinction"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Activer le débogage"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/language/resource.language.hu_hu/strings.po b/script.service.hyperion-control/resources/language/resource.language.hu_hu/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Hyperion kikapcsolása leállításkor"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Hibakeresés engedélyezése"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/language/resource.language.pl_pl/strings.po b/script.service.hyperion-control/resources/language/resource.language.pl_pl/strings.po
@@ -37,11 +37,6 @@ msgctxt "#32005"
 msgid "Disable Hyperion on shutdown"
 msgstr "Wyłącz Hyperion przy zamknięciu systemu"
 
-#:
-msgctxt "#32006"
-msgid "Enable Debug"
-msgstr "Włącz debugowanie"
-
 #:
 msgctxt "#32007"
 msgid "Show changelog after update"
diff --git a/script.service.hyperion-control/resources/lib/hyperion.py b/script.service.hyperion-control/resources/lib/hyperion.py
@@ -52,8 +52,7 @@ def _initialize(self) -> None:
 
     def notify(self, command: str) -> None:
         """Process the commands sent by the observables."""
-        if self._settings.debug:
-            self._logger.log(f"received command: {command}")
+        self._logger.log(f"received command: {command}")
         if command == "updateSettings":
             self.update_settings()
         else:
diff --git a/script.service.hyperion-control/resources/lib/interfaces.py b/script.service.hyperion-control/resources/lib/interfaces.py
@@ -44,7 +44,6 @@ class SettingsManager(Protocol):
     menu_enabled: bool
     show_changelog_on_update: bool
     tasks: int
-    debug: bool
     first_run: bool
 
     @property
diff --git a/script.service.hyperion-control/resources/lib/settings_manager.py b/script.service.hyperion-control/resources/lib/settings_manager.py
@@ -49,7 +49,6 @@ def __init__(
         self.menu_enabled: bool
         self.show_changelog_on_update: bool
         self.tasks: int
-        self.debug: bool
         self.first_run: bool
         self.read_settings()
 
@@ -108,7 +107,7 @@ def _set_bool(self, name: str, value: bool) -> None:
     def _log_set_outcome(self, name: str, value: Any, outcome: bool) -> None:
         if not outcome:
             self._logger.error(f"Error setting {name} to {value} (outcome={outcome})")
-        elif self.debug:
+        else:
             self._logger.log(f"Set {name} to {value}")
 
     def set_tasks(self, value: int) -> None:
@@ -140,7 +139,6 @@ def read_settings(self) -> None:
         self.enable_hyperion = get_bool("enableHyperion")
         self.disable_hyperion = get_bool("disableHyperion")
         self.show_changelog_on_update = get_bool("showChangelogOnUpdate")
-        self.debug = get_bool("debug")
         self.first_run = get_bool("firstRun")
         self.current_version = get_string("currAddonVersion")
 
@@ -155,8 +153,7 @@ def read_settings(self) -> None:
         self.tasks = get_int("tasks")
         self.rev += 1
 
-        if self.debug:
-            self._log_settings()
+        self._log_settings()
 
     def _log_settings(self) -> None:
         log = self._logger.log
@@ -172,7 +169,6 @@ def _log_settings(self) -> None:
         log(f"Audio enabled:         {self.audio_enabled}")
         log(f"Pause enabled:         {self.pause_enabled}")
         log(f"Menu enabled:          {self.menu_enabled}")
-        log(f"Debug enabled:         {self.debug}")
         log(f"ChangelogOnUpdate:     {self.show_changelog_on_update}")
         log(f"tasks:                 {self.tasks}")
         log(f"first run:             {self.first_run}")
diff --git a/script.service.hyperion-control/resources/settings.xml b/script.service.hyperion-control/resources/settings.xml
@@ -8,7 +8,6 @@
         <setting id="enableHyperion" type="bool" label="32004" default="false" />
         <setting id="disableHyperion" type="bool" label="32005" default="false" />
         <setting id="showChangelogOnUpdate" type="bool" label="32007" default="true" visible="true" />
-        <setting id="debug" type="bool" label="32006" default="false" />
         <setting id="firstRun" type="bool" label="32000" default="true" visible="false" />
         <setting id="currAddonVersion" type="text" default="" visible="false" />
     </category>
