Skip to content
This repository was archived by the owner on Oct 15, 2019. It is now read-only.

Commit d6ad1fd

Browse files
committed
1 parent a647611 commit d6ad1fd

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"sass-loader": "7.1.0",
6666
"style-loader": "0.23.0",
6767
"terser-webpack-plugin": "1.1.0",
68+
"typescript": "^3.1.6",
6869
"url-loader": "1.1.1",
6970
"webpack": "4.19.1",
7071
"webpack-dev-server": "3.1.9",

scripts/utils/verifyTypeScriptSetup.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ function verifyTypeScriptSetup() {
5353
// Ensure typescript is installed
5454
let ts;
5555
try {
56-
ts = require(resolve.sync('typescript'));
56+
// TODO: we temporarily added typescript to react-scripts because of https://github.com/facebook/create-react-app/issues/5647
57+
ts = require(resolve.sync('typescript', {
58+
basedir: paths.appNodeModules,
59+
}));
5760
} catch (_) {
5861
console.error(
5962
chalk.bold.red(

yarn.lock

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8768,6 +8768,11 @@ typedarray@^0.0.6:
87688768
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
87698769
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
87708770

8771+
typescript@^3.1.6:
8772+
version "3.1.6"
8773+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.1.6.tgz#b6543a83cfc8c2befb3f4c8fba6896f5b0c9be68"
8774+
integrity sha512-tDMYfVtvpb96msS1lDX9MEdHrW4yOuZ4Kdc4Him9oU796XldPYF/t2+uKoX0BBa0hXXwDlqYQbXY5Rzjzc5hBA==
8775+
87718776
uglify-es@^3.3.4:
87728777
version "3.3.9"
87738778
resolved "https://registry.yarnpkg.com/uglify-es/-/uglify-es-3.3.9.tgz#0c1c4f0700bed8dbc124cdb304d2592ca203e677"

0 commit comments

Comments
 (0)