Skip to content

Commit 1658890

Browse files
committed
Refactor test data into fixture
1 parent 8177ecd commit 1658890

File tree

3 files changed

+13
-25
lines changed

3 files changed

+13
-25
lines changed

.coveragerc

+1
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@
55
exclude_also =
66
# Don't complain if non-runnable code isn't run:
77
if __name__ == .__main__.:
8+
if TYPE_CHECKING:

.ruff.toml

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
fix = true
12
target-version = "py313" # Pin Ruff to Python 3.13
23
line-length = 88
34
output-format = "full"

tests/test_build_docs_versions.py

+11-25
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
from __future__ import annotations
2+
3+
import pytest
4+
15
from build_docs import Version, Versions
26

37

4-
def test_filter_default() -> None:
5-
# Arrange
6-
versions = Versions([
8+
@pytest.fixture
9+
def versions() -> Versions:
10+
return Versions([
711
Version(name="3.14", status="in development", branch_or_tag=""),
812
Version(name="3.13", status="stable", branch_or_tag=""),
913
Version(name="3.12", status="stable", branch_or_tag=""),
@@ -12,6 +16,8 @@ def test_filter_default() -> None:
1216
Version(name="3.9", status="security-fixes", branch_or_tag=""),
1317
])
1418

19+
20+
def test_filter_default(versions) -> None:
1521
# Act
1622
filtered = versions.filter()
1723

@@ -23,35 +29,15 @@ def test_filter_default() -> None:
2329
]
2430

2531

26-
def test_filter_one() -> None:
27-
# Arrange
28-
versions = Versions([
29-
Version(name="3.14", status="in development", branch_or_tag=""),
30-
Version(name="3.13", status="stable", branch_or_tag=""),
31-
Version(name="3.12", status="stable", branch_or_tag=""),
32-
Version(name="3.11", status="security-fixes", branch_or_tag=""),
33-
Version(name="3.10", status="security-fixes", branch_or_tag=""),
34-
Version(name="3.9", status="security-fixes", branch_or_tag=""),
35-
])
36-
32+
def test_filter_one(versions) -> None:
3733
# Act
3834
filtered = versions.filter(["3.13"])
3935

4036
# Assert
4137
assert filtered == [Version(name="3.13", status="security-fixes", branch_or_tag="")]
4238

4339

44-
def test_filter_multiple() -> None:
45-
# Arrange
46-
versions = Versions([
47-
Version(name="3.14", status="in development", branch_or_tag=""),
48-
Version(name="3.13", status="stable", branch_or_tag=""),
49-
Version(name="3.12", status="stable", branch_or_tag=""),
50-
Version(name="3.11", status="security-fixes", branch_or_tag=""),
51-
Version(name="3.10", status="security-fixes", branch_or_tag=""),
52-
Version(name="3.9", status="security-fixes", branch_or_tag=""),
53-
])
54-
40+
def test_filter_multiple(versions) -> None:
5541
# Act
5642
filtered = versions.filter(["3.13", "3.14"])
5743

0 commit comments

Comments
 (0)