Skip to content

customCache match method maybe get undefined input #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
wszgrcy opened this issue Mar 20, 2025 · 1 comment · Fixed by #1280
Closed
1 of 5 tasks

customCache match method maybe get undefined input #1249

wszgrcy opened this issue Mar 20, 2025 · 1 comment · Fixed by #1280
Labels
bug Something isn't working

Comments

@wszgrcy
Copy link

wszgrcy commented Mar 20, 2025

System Info

electron 32.2.7
windows 10 19045.4717

Environment/Platform

  • Website/web-app
  • Browser extension
  • Server-side (e.g., Node.js, Deno, Bun)
  • Desktop app (e.g., Electron)
  • Other (e.g., VSCode extension)

Description

export class ProxyCache {

  constructor(

  ) {

  }
  async match(request: string): Promise<FileResponse | undefined> {
// request maybe undefined in model request
}}
env.customCache=new ProxyCache() 

in 3.3.3 worked in 3.4.0 will receive undefined
not all undefined, But it's an additional undefined call

Reproduction

  1. use customCache
  2. request Xenova/bge-base-zh-v1.5
  3. match method receive undefined and throw error
@wszgrcy wszgrcy added the bug Something isn't working label Mar 20, 2025
@xenova
Copy link
Collaborator

xenova commented Apr 14, 2025

Thanks for the report - this will be fixed by #1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants