Skip to content

Commit 9d3e0e5

Browse files
authored
Resolve #2431: Remove macos-13 from tests (#2906)
* Resolve #2431: Remove macos-13 from tests As discussed in #2431 since there are no better macos runners available and the intel macos runners are failing for quite some time now we now have little choice other than to stop using macos in the CI.
1 parent df85979 commit 9d3e0e5

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,7 @@ jobs:
4141
fail-fast: false
4242
matrix:
4343
python-version: ["3.10", "3.11", "3.12", "3.13"]
44-
os: ["ubuntu-latest", "macos-13", "windows-latest"]
45-
exclude:
46-
- os: macos-13
47-
python-version: "3.13"
44+
os: ["ubuntu-latest", "windows-latest"]
4845
runs-on: ${{ matrix.os }}
4946
steps:
5047
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -82,30 +79,12 @@ jobs:
8279
# cpu version of pytorch
8380
pip install -e .[test]
8481
- name: Test with pytest
85-
# MacOS tests are currently too flaky and will fail almost each time. Thus, continue (green checkmark) even if
86-
# they fail, but add a notice so that the failure is not completely silent
87-
continue-on-error: ${{ matrix.os == 'macos-13' }}
8882
shell: bash
8983
env:
9084
HF_TOKEN: ${{ secrets.HF_TOKEN }}
9185
TRANSFORMERS_IS_CI: 1
9286
run: |
93-
set +e
9487
make test
95-
status=$?
96-
# Post a notice only if this is macOS AND tests failed
97-
if [ "$status" -ne 0 ] && [ "${{ matrix.os }}" = "macos-13" ]; then
98-
{
99-
echo "## ⚠️ macOS tests failed"
100-
echo ""
101-
echo "- OS: ${{ matrix.os }}"
102-
echo "- Python: ${{ matrix.python-version }}"
103-
echo ""
104-
echo "Check the logs from this step for details."
105-
} >> "$GITHUB_STEP_SUMMARY"
106-
fi
107-
# Return the real status. On macOS this won't fail the job because of continue-on-error.
108-
exit $status
10988
- name: Dump cache content and diff
11089
# This is just debug info so that we can monitor if the model cache diverges substantially
11190
# over time and what the diverging model is.

0 commit comments

Comments
 (0)