Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customising dictionary for identifying proper nouns #191

Closed
rmrbytes opened this issue Jul 31, 2019 · 2 comments
Closed

customising dictionary for identifying proper nouns #191

rmrbytes opened this issue Jul 31, 2019 · 2 comments

Comments

@rmrbytes
Copy link

When using this wonderful library to identify pronouns to names, it works well for popular names like John and Jane. However, it does not recognise many other names (perhaps due to the dictionary having US names). For example:

Given text: John and Jane are neighbours. She admires him because he works hard.

Pronouns and their references:
She => Jane
him => John
he => John

But

Given text: Ram and Sita are neighbours. She admires him because he works hard.

Pronouns and their references:
him => Ram and Sita
he => Ram and Sita

I tried adding

add_dict={"Sita": ["woman", "girl"], "Ram": ["man", "boy"]}
coref = neuralcoref.NeuralCoref(nlp.vocab, conv_dict=add_dict)

yet

Given text: Ram and Sita are neighbours. She admires him because he works hard.

Pronouns and their references:
She => Ram and Sita
him => Ram and Sita
he => Ram and Sita

Is there any reason it is not accepting the added words? Thanks

@munaAchyuta
Copy link

yes, i'm too facing same problem. this is a common issue for new domain . what should be the solution ?
don't see training from beginning with new domain data(small size) is feasible. is there transfer learning possible ?

@svlandeg
Copy link
Collaborator

Thanks for the report! Merging with Issue #215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants