Difference in Flux scheduler configuration max_shift #10675
Labels
bug
Something isn't working
contributions-welcome
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
|
oh yeah not intentional! do you want to help us change? the config in scheduler is correct, so have should not affect the results https://huggingface.co/black-forest-labs/FLUX.1-dev/blob/main/scheduler/scheduler_config.json#L7 |
yiyixuxu
added
good first issue
|
the value is here, too: Might still not get used as you say, if |
puhuk
added a commit
to puhuk/diffusers
that referenced
this issue
Feb 17, 2025
…ingface#10675) This PR updates the max_shift value in flux to 1.15 for consistency across the codebase. In addition to modifying max_shift in flux, all related functions that copy and use this logic, such as calculate_shift in `src/diffusers/pipelines/stable_diffusion_3/pipeline_stable_diffusion_3_img2img.py`, have also been updated to ensure uniform behavior.
6 tasks
hlky
pushed a commit
that referenced
this issue
Feb 18, 2025
…) (#10807) This PR updates the max_shift value in flux to 1.15 for consistency across the codebase. In addition to modifying max_shift in flux, all related functions that copy and use this logic, such as calculate_shift in `src/diffusers/pipelines/stable_diffusion_3/pipeline_stable_diffusion_3_img2img.py`, have also been updated to ensure uniform behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Could you please check if the value of 1.16 here...
diffusers/src/diffusers/pipelines/flux/pipeline_flux.py
Line 78 in 658e24e
...is intentional or maybe a typo?
max_shiftis 1.15 both in the model configuration...https://huggingface.co/black-forest-labs/FLUX.1-dev/blob/main/scheduler/scheduler_config.json
...and in the original inference code by BFL:
https://github.com/black-forest-labs/flux/blob/d06f82803f5727a91b0cf93fcbb09d920761fba1/src/flux/sampling.py#L214
Reproduction
Logs
System Info
Who can help?
@yiyixuxu @DN6
The text was updated successfully, but these errors were encountered: