Skip to content

support customized dataLoaders? #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ifiaposto opened this issue Jan 5, 2025 · 1 comment
Closed

support customized dataLoaders? #3322

ifiaposto opened this issue Jan 5, 2025 · 1 comment

Comments

@ifiaposto
Copy link

DataLoaderAdapter, and as a result DataLoaderShard returned by prepare, sets:

self.base_dataloader = DataLoader(dataset, batch_sampler=batch_sampler, **kwargs)

I think it would be very useful if prepare_dataloader passed the type of the original dataloader when creating the DataLoaderShard and extend DataloaderShard to support customized dataloader types. Otherwise, the functionality seems very limited.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant