Merge pull request #12 from hudl/DestroyHostIfNotUsed

Don't call destroy host if instance mgr actively used

Author: debbibel

README.md

@@ -14,8 +14,8 @@ allprojects {
 }
 
 dependencies {
-  // Version will correspond to its dependnecy on React Native
-  compile 'com.github.hudl:react-native-android-fragment:v0.43.2'
+  // Version will correspond to its dependency on React Native
+  compile 'com.github.hudl:react-native-android-fragment:v0.46.2.2'
 }
 ```
 
@@ -25,7 +25,7 @@ Or Maven:
 <dependency>
   <groupId>com.hudl.oss</groupId>
   <artifactId>react-native-android-fragment</artifactId>
-  <version>0.43.2</version>
+  <version>0.46.2.2</version>
 </dependency>
 ```
 

build.gradle

@@ -1,6 +1,6 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 
-def libraryVersion = '0.43.2'
+def libraryVersion = '0.46.2.2'
 
 buildscript {
     repositories {

react-native-android-fragment/src/main/java/com/hudl/oss/react/fragment/ReactFragment.java

@@ -155,12 +155,12 @@ public void onDestroy() {
         }
         if (getReactNativeHost().hasInstance()) {
             ReactInstanceManager reactInstanceMgr = getReactNativeHost().getReactInstanceManager();
-            reactInstanceMgr.onHostDestroy(getActivity());
 
             // onDestroy may be called on a ReactFragment after another ReactFragment has been
             // created and resumed with the same React Instance Manager. Make sure we only clean up
             // host's React Instance Manager if no other React Fragment is actively using it.
             if (reactInstanceMgr.getLifecycleState() != LifecycleState.RESUMED) {
+                reactInstanceMgr.onHostDestroy(getActivity());
                 getReactNativeHost().clear();
             }
         }