Make server URL base variable names less ambiguous

Author: semyon-slepov

config.go

@@ -34,12 +34,12 @@ type eureka struct {
 	ServerDNSName         string   // default ""
 	ServiceUrls           []string // default []
 	ServerPort            int      // default 7001
+	ServerURLBase         string   // default "eureka/v2"
 	PollIntervalSeconds   int      // default 30
 	EnableDelta           bool     // TODO: Support querying for deltas
 	PreferSameZone        bool     // default false
 	RegisterWithEureka    bool     // default false
 	Retries               int      // default 3
-	ServerContext         string   // default "eureka/v2"
 }
 
 // ReadConfig from a file location. Minimal error handling. Just bails and passes up
@@ -68,7 +68,7 @@ func (c *Config) fillDefaults() {
 	if c.Eureka.PollIntervalSeconds == 0 {
 		c.Eureka.PollIntervalSeconds = 30
 	}
-	if c.Eureka.ServerContext == "" {
-		c.Eureka.ServerContext = "eureka/v2"
+	if len(c.Eureka.ServerURLBase) == 0 {
+		c.Eureka.ServerURLBase = "eureka/v2"
 	}
 }

connection.go

@@ -20,7 +20,7 @@ func (e *EurekaConnection) SelectServiceURL() string {
 		e.discoveryTtl = make(chan struct{}, 1)
 	}
 	if e.DNSDiscovery && len(e.discoveryTtl) == 0 {
-		servers, ttl, err := discoverDNS(e.DiscoveryZone, e.ServicePort, e.ServerContext)
+		servers, ttl, err := discoverDNS(e.DiscoveryZone, e.ServicePort, e.ServerURLBase)
 		if err != nil {
 			return choice(e.ServiceUrls)
 		}
@@ -68,7 +68,7 @@ func NewConnFromConfig(conf Config) (c EurekaConnection) {
 		log.Warning("UseDNSForServiceUrls is an experimental option")
 		c.DNSDiscovery = true
 		c.DiscoveryZone = conf.Eureka.DNSDiscoveryZone
-		c.ServerContext = conf.Eureka.ServerContext
+		c.ServerURLBase = conf.Eureka.ServerURLBase
 	}
 	return c
 }

dns_discover.go

@@ -14,7 +14,7 @@ const azURL = "http://169.254.169.254/latest/meta-data/placement/availability-zo
 
 var ErrNotInAWS = fmt.Errorf("Not in AWS")
 
-func discoverDNS(domain string, port int, context string) (servers []string, ttl time.Duration, err error) {
+func discoverDNS(domain string, port int, urlBase string) (servers []string, ttl time.Duration, err error) {
 	r, _ := region()
 
 	// all DNS queries must use the FQDN
@@ -35,7 +35,7 @@ func discoverDNS(domain string, port int, context string) (servers []string, ttl
 		}
 		for _, instance := range instances {
 			// format the service URL
-			servers = append(servers, fmt.Sprintf("http://%s:%d/%s", instance, port, context))
+			servers = append(servers, fmt.Sprintf("http://%s:%d/%s", instance, port, urlBase))
 		}
 	}
 	return

struct.go

@@ -25,7 +25,7 @@ type EurekaConnection struct {
 	DNSDiscovery   bool
 	DiscoveryZone  string
 	discoveryTtl   chan struct{}
-	ServerContext  string
+	ServerURLBase  string
 	UseJson        bool
 }