Skip to content

Commit b1fb2b6

Browse files
committed
Keep exported types same
1 parent 18c5d44 commit b1fb2b6

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/index.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,15 @@ interface PortalNodeBase<C extends Component<any>> {
3333
// latest placeholder we replaced. This avoids some race conditions.
3434
unmount(expectedPlaceholder?: Node): void;
3535
}
36-
export interface HtmlBlockPortalNode<C extends Component<any> = Component<any>> extends PortalNodeBase<C> {
36+
export interface HtmlPortalNode<C extends Component<any> = Component<any>> extends PortalNodeBase<C> {
3737
element: HTMLElement;
38-
elementType: typeof ELEMENT_TYPE_HTML_BLOCK;
39-
}
40-
export interface HtmlInlinePortalNode<C extends Component<any> = Component<any>> extends PortalNodeBase<C> {
41-
element: HTMLElement;
42-
elementType: typeof ELEMENT_TYPE_HTML_INLINE;
38+
elementType: typeof ELEMENT_TYPE_HTML_BLOCK | typeof ELEMENT_TYPE_HTML_INLINE;
4339
}
4440
export interface SvgPortalNode<C extends Component<any> = Component<any>> extends PortalNodeBase<C> {
4541
element: SVGElement;
4642
elementType: typeof ELEMENT_TYPE_SVG;
4743
}
48-
type AnyPortalNode<C extends Component<any> = Component<any>> = HtmlBlockPortalNode<C> | HtmlInlinePortalNode<C> | SvgPortalNode<C>;
44+
type AnyPortalNode<C extends Component<any> = Component<any>> = HtmlPortalNode<C> | SvgPortalNode<C>;
4945

5046

5147
const validateElementType = (domElement: Element, elementType: ANY_ELEMENT_TYPE) => {
@@ -257,9 +253,9 @@ class OutPortal<C extends Component<any>> extends React.PureComponent<OutPortalP
257253
}
258254

259255
const createHtmlPortalNode = createPortalNode.bind(null, ELEMENT_TYPE_HTML_BLOCK) as
260-
<C extends Component<any> = Component<any>>(options?: Options) => HtmlBlockPortalNode<C>;
256+
<C extends Component<any> = Component<any>>(options?: Options) => HtmlPortalNode<C>;
261257
const createHtmlInlinePortalNode = createPortalNode.bind(null, ELEMENT_TYPE_HTML_INLINE) as
262-
<C extends Component<any> = Component<any>>(options?: Options) => HtmlInlinePortalNode<C>;
258+
<C extends Component<any> = Component<any>>(options?: Options) => HtmlPortalNode<C>;
263259
const createSvgPortalNode = createPortalNode.bind(null, ELEMENT_TYPE_SVG) as
264260
<C extends Component<any> = Component<any>>(options?: Options) => SvgPortalNode<C>;
265261

0 commit comments

Comments
 (0)