chore: refactor to app and clone handler down to router

Author: tzilist

src/app.rs

@@ -11,6 +11,7 @@ use std::{
 
 use crate::{
     body::Body,
+    endpoint::BoxedEndpoint,
     endpoint::Endpoint,
     extract::Extract,
     middleware::{logger::RootLogger, RequestContext},
@@ -26,6 +27,7 @@ use crate::{
 pub struct App<Data> {
     data: Data,
     router: Router<Data>,
+    default_handler: Arc<BoxedEndpoint<Data>>,
 }
 
 impl<Data: Clone + Send + Sync + 'static> App<Data> {
@@ -35,6 +37,9 @@ impl<Data: Clone + Send + Sync + 'static> App<Data> {
         let mut app = App {
             data,
             router: Router::new(),
+            default_handler: Arc::new(BoxedEndpoint::new(async || {
+                http::status::StatusCode::NOT_FOUND
+            })),
         };
 
         // Add RootLogger as a default middleware
@@ -53,8 +58,8 @@ impl<Data: Clone + Send + Sync + 'static> App<Data> {
     }
 
     /// Set the default handler for the app, a fallback function when there is no match to the route requested
-    pub fn default_handler<T: Endpoint<Data, U>, U>(&mut self, ep: T) -> &mut Self {
-        self.router.set_default_handler(ep);
+    pub fn default_handler<T: Endpoint<Data, U>, U>(&mut self, handler: T) -> &mut Self {
+        self.default_handler = Arc::new(BoxedEndpoint::new(handler));
         self
     }
 
@@ -69,6 +74,7 @@ impl<Data: Clone + Send + Sync + 'static> App<Data> {
         Server {
             data: self.data,
             router: Arc::new(self.router),
+            default_handler: Arc::clone(&self.default_handler),
         }
     }
 
@@ -100,6 +106,7 @@ impl<Data: Clone + Send + Sync + 'static> App<Data> {
 struct Server<Data> {
     data: Data,
     router: Arc<Router<Data>>,
+    default_handler: Arc<BoxedEndpoint<Data>>,
 }
 
 impl<Data: Clone + Send + Sync + 'static> Service for Server<Data> {
@@ -111,6 +118,7 @@ impl<Data: Clone + Send + Sync + 'static> Service for Server<Data> {
     fn call(&mut self, req: http::Request<hyper::Body>) -> Self::Future {
         let data = self.data.clone();
         let router = self.router.clone();
+        let default_handler = self.default_handler.clone();
 
         let req = req.map(Body::from);
         let path = req.uri().path().to_owned();
@@ -122,7 +130,7 @@ impl<Data: Clone + Send + Sync + 'static> Service for Server<Data> {
                     endpoint,
                     params,
                     middleware,
-                } = router.route(&path, &method);
+                } = router.route(&path, &method, &default_handler);
 
                 let ctx = RequestContext {
                     app_data: data,

src/head.rs

@@ -71,7 +71,7 @@ impl<T: Send + 'static + std::str::FromStr, S: 'static> Extract<S> for Path<T> {
                 Ok(t) => future::ok(Path(t)),
                 Err(_) => future::err(http::status::StatusCode::BAD_REQUEST.into_response()),
             },
-            None => future::err(http::status::StatusCode::BAD_REQUEST.into_response()),
+            None => future::err(http::status::StatusCode::INTERNAL_SERVER_ERROR.into_response()),
         }
     }
 }

src/router.rs

@@ -13,7 +13,6 @@ use path_table::{PathTable, RouteMatch};
 pub struct Router<Data> {
     table: PathTable<ResourceData<Data>>,
     middleware_base: Vec<Arc<dyn Middleware<Data> + Send + Sync>>,
-    default_handler: Arc<BoxedEndpoint<Data>>,
 }
 
 pub(crate) struct RouteResult<'a, Data> {
@@ -22,10 +21,6 @@ pub(crate) struct RouteResult<'a, Data> {
     pub(crate) middleware: &'a [Arc<dyn Middleware<Data> + Send + Sync>],
 }
 
-pub async fn base_default_handler() -> http::status::StatusCode {
-    http::status::StatusCode::NOT_FOUND
-}
-
 fn route_match_success<'a, Data>(
     route: &'a ResourceData<Data>,
     route_match: RouteMatch<'a>,
@@ -50,7 +45,7 @@ fn route_match_success<'a, Data>(
 
 fn route_match_failure<'a, Data>(
     endpoint: &'a BoxedEndpoint<Data>,
-    middleware: &'a Vec<Arc<dyn Middleware<Data> + Send + Sync>>,
+    middleware: &'a [Arc<dyn Middleware<Data> + Send + Sync>],
 ) -> RouteResult<'a, Data> {
     RouteResult {
         endpoint,
@@ -65,7 +60,6 @@ impl<Data: Clone + Send + Sync + 'static> Router<Data> {
         Router {
             table: PathTable::new(),
             middleware_base: Vec::new(),
-            default_handler: Arc::new(BoxedEndpoint::new(base_default_handler)),
         }
     }
 
@@ -75,7 +69,6 @@ impl<Data: Clone + Send + Sync + 'static> Router<Data> {
         Resource {
             table,
             middleware_base: &self.middleware_base,
-            default_handler: &self.default_handler,
         }
     }
 
@@ -116,26 +109,17 @@ impl<Data: Clone + Send + Sync + 'static> Router<Data> {
         self
     }
 
-    pub fn set_default_handler<T: Endpoint<Data, U>, U>(&mut self, ep: T) -> &mut Self {
-        self.default_handler = Arc::new(BoxedEndpoint::new(ep));
-        self
-    }
-
     pub(crate) fn route<'a>(
         &'a self,
         path: &'a str,
         method: &http::Method,
+        default_handler: &'a Arc<BoxedEndpoint<Data>>,
     ) -> RouteResult<'a, Data> {
         match self.table.route(path) {
             Some((route, route_match)) => route_match_success(route, route_match, method)
-                .or_else(|| {
-                    Some(route_match_failure(
-                        &self.default_handler,
-                        &self.middleware_base,
-                    ))
-                })
+                .or_else(|| Some(route_match_failure(default_handler, &self.middleware_base)))
                 .unwrap(),
-            None => route_match_failure(&self.default_handler, &self.middleware_base),
+            None => route_match_failure(default_handler, &self.middleware_base),
         }
     }
 }
@@ -148,7 +132,6 @@ impl<Data: Clone + Send + Sync + 'static> Router<Data> {
 pub struct Resource<'a, Data> {
     table: &'a mut PathTable<ResourceData<Data>>,
     middleware_base: &'a Vec<Arc<dyn Middleware<Data> + Send + Sync>>,
-    default_handler: &'a Arc<BoxedEndpoint<Data>>,
 }
 
 struct ResourceData<Data> {
@@ -168,7 +151,6 @@ impl<'a, Data> Resource<'a, Data> {
         let mut subrouter = Router {
             table: PathTable::new(),
             middleware_base: self.middleware_base.clone(),
-            default_handler: self.default_handler.clone(),
         };
         builder(&mut subrouter);
         *self.table = subrouter.table;
@@ -257,11 +239,14 @@ mod tests {
         path: &'a str,
         method: &'a http::Method,
     ) -> Option<Response> {
+        let default_handler = Arc::new(BoxedEndpoint::new(async || {
+            http::status::StatusCode::NOT_FOUND
+        }));
         let RouteResult {
             endpoint,
             params,
             middleware,
-        } = router.route(path, method);
+        } = router.route(path, method, &default_handler);
 
         let data = Data::default();
         let req = http::Request::builder()
@@ -285,7 +270,10 @@ mod tests {
         path: &str,
         method: &http::Method,
     ) -> Option<usize> {
-        let route_result = router.route(path, method);
+        let default_handler = Arc::new(BoxedEndpoint::new(async || {
+            http::status::StatusCode::NOT_FOUND
+        }));
+        let route_result = router.route(path, method, &default_handler);
         Some(route_result.middleware.len())
     }