Skip to content

Commit 0c98271

Browse files
author
Nicholas Young
committed
Rename cookies::CookiesExt to ContextExt
As discussed in #187, context extension traits should have an import path that explains their functionality, while being named after the traits they extend. Signed-off-by: Nicholas Young <[email protected]>
1 parent 75b03d5 commit 0c98271

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

examples/cookies.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#![feature(async_await)]
22

33
use cookie::Cookie;
4-
use tide::{cookies::CookiesExt, middleware::CookiesMiddleware, Context};
4+
use tide::{cookies::ContextExt, middleware::CookiesMiddleware, Context};
55

66
/// Tide will use the the `Cookies`'s `Extract` implementation to build this parameter.
77
///

src/cookies.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ impl CookieData {
2828
}
2929

3030
/// An extension to `Context` that provides cached access to cookies
31-
pub trait CookiesExt {
31+
pub trait ContextExt {
3232
/// returns a `Cookie` by name of the cookie
3333
fn get_cookie(&mut self, name: &str) -> Result<Option<Cookie<'static>>, StringError>;
3434

@@ -40,7 +40,7 @@ pub trait CookiesExt {
4040
fn remove_cookie(&mut self, cookie: Cookie<'static>) -> Result<(), StringError>;
4141
}
4242

43-
impl<State> CookiesExt for Context<State> {
43+
impl<State> ContextExt for Context<State> {
4444
fn get_cookie(&mut self, name: &str) -> Result<Option<Cookie<'static>>, StringError> {
4545
let cookie_data = self
4646
.extensions()

src/middleware/cookies.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use crate::{
99

1010
/// Middleware to work with cookies.
1111
///
12-
/// [`CookiesMiddleware`] along with [`CookiesExt`](crate::cookies::CookiesExt) provide smooth
12+
/// [`CookiesMiddleware`] along with [`ContextExt`](crate::cookies::ContextExt) provide smooth
1313
/// access to request cookies and setting/removing cookies from response. This leverages the
1414
/// [cookie](https://crates.io/crates/cookie) crate.
1515
/// This middleware parses cookies from request and caches them in the extension. Once the request
@@ -63,7 +63,7 @@ impl<Data: Send + Sync + 'static> Middleware<Data> for CookiesMiddleware {
6363
#[cfg(test)]
6464
mod tests {
6565
use super::*;
66-
use crate::{cookies::CookiesExt, Context};
66+
use crate::{cookies::ContextExt, Context};
6767
use cookie::Cookie;
6868
use futures::executor::block_on;
6969
use http_service::Body;

0 commit comments

Comments
 (0)