Skip to content

Commit c8fafd4

Browse files
committed
Merge pull request #253 from gsnedders/unittest-be-gone
Get rid of all remaining references to stdlib unittest; r=nobody!
2 parents 8cb66f2 + 1df7e5f commit c8fafd4

File tree

4 files changed

+314
-355
lines changed

4 files changed

+314
-355
lines changed

html5lib/tests/test_encoding.py

-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
from __future__ import absolute_import, division, unicode_literals
22

33
import os
4-
import unittest
5-
6-
try:
7-
unittest.TestCase.assertEqual
8-
except AttributeError:
9-
unittest.TestCase.assertEqual = unittest.TestCase.assertEquals
104

115
from .support import get_data_files, test_dir, errorMessage, TestData as _TestData
126
from html5lib import HTMLParser, inputstream

html5lib/tests/test_parser2.py

+31-42
Original file line numberDiff line numberDiff line change
@@ -2,63 +2,52 @@
22

33
import io
44

5+
import pytest
6+
57
from . import support # flake8: noqa
68
from html5lib import html5parser
79
from html5lib.constants import namespaces
8-
from html5lib import treebuilders
10+
from html5lib import parse
911

10-
import unittest
1112

1213
# tests that aren't autogenerated from text files
14+
def test_assertDoctypeCloneable():
15+
doc = parse('<!DOCTYPE HTML>', treebuilder="dom")
16+
assert doc.cloneNode(True) is not None
1317

1418

15-
class MoreParserTests(unittest.TestCase):
16-
17-
def setUp(self):
18-
self.dom_tree = treebuilders.getTreeBuilder("dom")
19-
20-
def test_assertDoctypeCloneable(self):
21-
parser = html5parser.HTMLParser(tree=self.dom_tree)
22-
doc = parser.parse('<!DOCTYPE HTML>')
23-
self.assertTrue(doc.cloneNode(True))
24-
25-
def test_line_counter(self):
26-
# http://groups.google.com/group/html5lib-discuss/browse_frm/thread/f4f00e4a2f26d5c0
27-
parser = html5parser.HTMLParser(tree=self.dom_tree)
28-
parser.parse("<pre>\nx\n&gt;\n</pre>")
19+
def test_line_counter():
20+
# http://groups.google.com/group/html5lib-discuss/browse_frm/thread/f4f00e4a2f26d5c0
21+
assert parse("<pre>\nx\n&gt;\n</pre>") is not None
2922

30-
def test_namespace_html_elements_0_dom(self):
31-
parser = html5parser.HTMLParser(tree=self.dom_tree, namespaceHTMLElements=True)
32-
doc = parser.parse("<html></html>")
33-
self.assertTrue(doc.childNodes[0].namespaceURI == namespaces["html"])
3423

35-
def test_namespace_html_elements_1_dom(self):
36-
parser = html5parser.HTMLParser(tree=self.dom_tree, namespaceHTMLElements=False)
37-
doc = parser.parse("<html></html>")
38-
self.assertTrue(doc.childNodes[0].namespaceURI is None)
24+
def test_namespace_html_elements_0_dom():
25+
doc = parse("<html></html>",
26+
treebuilder="dom",
27+
namespaceHTMLElements=True)
28+
assert doc.childNodes[0].namespaceURI == namespaces["html"]
3929

40-
def test_namespace_html_elements_0_etree(self):
41-
parser = html5parser.HTMLParser(namespaceHTMLElements=True)
42-
doc = parser.parse("<html></html>")
43-
self.assertTrue(doc.tag == "{%s}html" % (namespaces["html"],))
4430

45-
def test_namespace_html_elements_1_etree(self):
46-
parser = html5parser.HTMLParser(namespaceHTMLElements=False)
47-
doc = parser.parse("<html></html>")
48-
self.assertTrue(doc.tag == "html")
31+
def test_namespace_html_elements_1_dom():
32+
doc = parse("<html></html>",
33+
treebuilder="dom",
34+
namespaceHTMLElements=False)
35+
assert doc.childNodes[0].namespaceURI is None
4936

50-
def test_unicode_file(self):
51-
parser = html5parser.HTMLParser()
52-
parser.parse(io.StringIO("a"))
5337

38+
def test_namespace_html_elements_0_etree():
39+
doc = parse("<html></html>",
40+
treebuilder="etree",
41+
namespaceHTMLElements=True)
42+
assert doc.tag == "{%s}html" % (namespaces["html"],)
5443

55-
def buildTestSuite():
56-
return unittest.defaultTestLoader.loadTestsFromName(__name__)
5744

45+
def test_namespace_html_elements_1_etree():
46+
doc = parse("<html></html>",
47+
treebuilder="etree",
48+
namespaceHTMLElements=False)
49+
assert doc.tag == "html"
5850

59-
def main():
60-
buildTestSuite()
61-
unittest.main()
6251

63-
if __name__ == '__main__':
64-
main()
52+
def test_unicode_file():
53+
assert parse(io.StringIO("a")) is not None

0 commit comments

Comments
 (0)