socktoa.c:

Damir Tomic · Damir Tomic · commit 85e8d4de9c10 · 2015-06-16T18:48:26.000+02:00
added new function which replaces EXPECT_NE from gtest

bk: 5580535aj-T_dALHNRy4XieqdNTHng
diff --git a/tests/libntp/run-test-socktoa.c b/tests/libntp/run-test-socktoa.c
@@ -55,7 +55,7 @@ int main(int argc, char *argv[])
   RUN_TEST(test_ScopedIPv6AddressWithPort, 40);
   RUN_TEST(test_HashEqual, 65);
   RUN_TEST(test_HashNotEqual, 73);
-  RUN_TEST(test_IgnoreIPv6Fields, 82);
+  RUN_TEST(test_IgnoreIPv6Fields, 84);
 
   return (UnityEnd());
 }
diff --git a/tests/libntp/socktoa.c b/tests/libntp/socktoa.c
@@ -77,6 +77,10 @@ void test_HashNotEqual(void) {
 
 	TEST_ASSERT_FALSE(IsEqual(input1, input2));
 	//TODO : EXPECT_NE(sock_hash(&input1), sock_hash(&input2));
+	//Damir's suggestion below:
+	TEST_ASSERT_FALSE(sock_hash(&input1) == sock_hash(&input2)); 
+	//NOTE: sock_hash returns u_short, so you can compare it with ==
+	//for complex structures you have to write an additional function like bool compare(a,b) 
 }
 
 void test_IgnoreIPv6Fields(void) {

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ int main(int argc, char *argv[])`
`55`	`55`	`RUN_TEST(test_ScopedIPv6AddressWithPort, 40);`
`56`	`56`	`RUN_TEST(test_HashEqual, 65);`
`57`	`57`	`RUN_TEST(test_HashNotEqual, 73);`
`58`		`- RUN_TEST(test_IgnoreIPv6Fields, 82);`
	`58`	`+ RUN_TEST(test_IgnoreIPv6Fields, 84);`
`59`	`59`
`60`	`60`	`return (UnityEnd());`
`61`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,10 @@ void test_HashNotEqual(void) {`
`77`	`77`
`78`	`78`	`TEST_ASSERT_FALSE(IsEqual(input1, input2));`
`79`	`79`	`//TODO : EXPECT_NE(sock_hash(&input1), sock_hash(&input2));`
	`80`	`+ //Damir's suggestion below:`
	`81`	`+ TEST_ASSERT_FALSE(sock_hash(&input1) == sock_hash(&input2));`
	`82`	`+ //NOTE: sock_hash returns u_short, so you can compare it with ==`
	`83`	`+ //for complex structures you have to write an additional function like bool compare(a,b)`
`80`	`84`	`}`
`81`	`85`
`82`	`86`	`void test_IgnoreIPv6Fields(void) {`