Skip to content

Commit 85076e4

Browse files
committed
Update to packed_simd 0.3.3 to make sure the improvements to NEON support are used.
Closes #23.
1 parent 54cf6eb commit 85076e4

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ fast-legacy-encode = ["fast-hangul-encode",
3232

3333
[dependencies]
3434
cfg-if = "0.1.0"
35-
packed_simd = { version = "0.3.2", optional = true }
35+
packed_simd = { version = "0.3.3", optional = true }
3636
serde = { version = "1.0", optional = true }
3737

3838
[dev-dependencies]

README.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,29 @@ targets:
137137
* x86_64
138138
* i686
139139
* aarch64
140+
* thumbv7neon
140141

141-
If you use nightly Rust, use targets whose first component is one of the
142+
If you use nightly Rust, you use targets whose first component is one of the
142143
above, and you are prepared _to have to revise your configuration when updating
143144
Rust_, you should enable this feature. Otherwise, please _do not_ enable this
144145
feature.
145146

147+
_Note!_ If you are compiling for a target that does not have 128-bit SIMD
148+
enabled as part of the target definition and you are enabling 128-bit SIMD
149+
using `-C target_feature`, you need to enable the `core_arch` Cargo feature
150+
for `packed_simd` to compile a crates.io snapshot of `core_arch` instead of
151+
using the standard-library copy of `core::arch`, because the `core::arch`
152+
module of the pre-compiled standard library has been compiled with the
153+
assumption that the CPU doesn't have 128-bit SIMD. At present this applies
154+
mainly to 32-bit ARM targets whose first component does not include the
155+
substring `neon`.
156+
157+
The encoding_rs side of things has not been properly set up for POWER,
158+
PowerPC, MIPS, etc., SIMD at this time, so even if you were to follow
159+
the advice from the previous paragraph, you probably shouldn't use
160+
the `simd-accel` option on the less mainstream architectures at this
161+
time.
162+
146163
Used by Firefox.
147164

148165
### `serde`

0 commit comments

Comments
 (0)