Skip to content
This repository was archived by the owner on May 1, 2021. It is now read-only.

Keep this or… #7

Open
hrbrmstr opened this issue Jan 29, 2017 · 6 comments
Open

Keep this or… #7

hrbrmstr opened this issue Jan 29, 2017 · 6 comments

Comments

@hrbrmstr
Copy link
Owner

abandon it and support https://github.com/pdil/usmap @hadley @rdinter ?

FWIW I have a new pkg ready that only uses sf (halfway done porting the ++gd independent elide-ing code to sf @rdinter added, too) so we cld keep both.

@hadley
Copy link

hadley commented Jan 29, 2017

Combining the two efforts seems reasonable to me

@hadley
Copy link

hadley commented Jan 29, 2017

Would be good to ensure similar interface to https://github.com/ropensci/USAboundaries too

@hadley
Copy link

hadley commented Jan 29, 2017

Or maybe integrate all three somehow?

@rdinter
Copy link
Contributor

rdinter commented Jan 29, 2017

It looks like the the usmap package has the same shapefiles as albersusa since it references Moving The Earth (well, Alaska & Hawaii) With R and performs the same elide functions for Alaska and Hawaii in its source code. It looks like it could benefit from a lot of the albersusa functionality, for example there does not appear to be any way to change the map's projection since the R objects used for plotting have been fortified to data.frames with the albers equal area projection as the SpatialPolygon's current projection. I think it'd be great to integrate all 3 packages referenced in some way.

Since I'm new to package development, I don't know if it's easier to jump aboard the usmap train or implement some of the usmap functions to albersusa. But I'm willing to help out.

@bhaskarvk
Copy link

https://github.com/rveciana/d3-composite-projections seems to have some really nice composite projections. If you do end up reworking/merging the R pkgs, please consider supporting the above mentioned projections too.

@dblodgett-usgs
Copy link

@hrbrmstr - what package are you referring to that is sf-only and has an elide capability?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants