refactor tests

Author: snowch

pre_push_verifications.sh

@@ -10,7 +10,7 @@ black bin/ tests/ hpecp/
 #flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
 flake8 --docstring-convention numpy bin/ hpecp/
 
-flake8 --ignore=D,E501 tests/*.py # don't verify documentation in tests
+flake8 --ignore=D,E501 tests/cli_test.py # don't verify documentation in tests
 
 tox -e py35 -- tests/
 

tests/config_mock_api.py

@@ -0,0 +1,38 @@
+# (C) Copyright [2020] Hewlett Packard Enterprise Development LP
+#
+# Permission is hereby granted, free of charge, to any person obtaining a
+# copy of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom the
+# Software is furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+# OTHER DEALINGS IN THE SOFTWARE.
+
+
+from .base_test import BaseTestCase, MockResponse
+
+
+def mockApiSetup():
+
+    BaseTestCase.registerHttpPostHandler(
+        url="https://127.0.0.1:8080/api/v2/config/auth",
+        response=MockResponse(
+            json_data={},
+            status_code=200,
+            headers={
+                "location": (
+                    "/api/v1/session/df1bfacb-xxxx-xxxx-xxxx-c8f57d8f3c71"
+                )
+            },
+        ),
+    )

tests/config_test.py

@@ -25,58 +25,15 @@
 
 from hpecp import ContainerPlatformClient
 
+from .base_test import BaseTestCase, MockResponse
+from .config_mock_api import mockApiSetup
 
-class MockResponse:
-    def __init__(
-        self,
-        json_data,
-        status_code,
-        headers,
-        raise_for_status_flag=False,
-        text_data="",
-    ):
-        self.json_data = json_data
-        self.text = text_data
-        self.status_code = status_code
-        self.raise_for_status_flag = raise_for_status_flag
-        self.headers = headers
+# setup the mock data
+mockApiSetup()
 
-    def raise_for_status(self):
-        if self.raise_for_status_flag:
-            self.text = "some error occurred"
-            raise requests.exceptions.HTTPError()
-        else:
-            return
 
-    def json(self):
-        return self.json_data
-
-
-class TestTentants(TestCase):
-    def mocked_requests_post(*args, **kwargs):
-        if args[0] == "https://127.0.0.1:8080/api/v1/login":
-            return MockResponse(
-                json_data={},
-                status_code=200,
-                headers={
-                    "location": (
-                        "/api/v1/session/df1bfacb-xxxx-xxxx-xxxx-c8f57d8f3c71"
-                    )
-                },
-            )
-        elif args[0] == "https://127.0.0.1:8080/api/v2/config/auth":
-            return MockResponse(
-                json_data={},
-                status_code=200,
-                headers={
-                    "location": (
-                        "/api/v1/session/df1bfacb-xxxx-xxxx-xxxx-c8f57d8f3c71"
-                    )
-                },
-            )
-        raise RuntimeError("Unhandle POST request: " + args[0])
-
-    @patch("requests.post", side_effect=mocked_requests_post)
+class TestTentants(BaseTestCase):
+    @patch("requests.post", side_effect=BaseTestCase.httpPostHandlers)
     def test_epic_tenant_list(self, mock_post):
 
         client = ContainerPlatformClient(