Merge pull request #62 from hpe-container-platform-community/improve_code_coverage

add test for missing config file

Author: snowch

tests/cli/cli_test.py

@@ -25,7 +25,12 @@
 from unittest import TestCase
 
 import requests
-from mock import patch
+import six
+
+if six.PY2:
+    from io import BytesIO as StringIO  # noqa: F811
+else:
+    from io import StringIO
 
 
 class MockResponse:
@@ -55,70 +60,6 @@ def json(self):
 
 
 class TestCLI(TestCase):
-
-    # pylint: disable=no-method-argument
-    def mocked_requests_post(*args, **kwargs):
-        if args[0] == "https://127.0.0.1:8080/api/v1/login":
-            return MockResponse(
-                json_data={},
-                status_code=200,
-                headers={
-                    "location": (
-                        "/api/v1/session/df1bfacb-xxxx-xxxx-xxxx-c8f57d8f3c71"
-                    )
-                },
-            )
-        raise RuntimeError("Unhandle POST request: " + args[0])
-
-    # pylint: disable=no-method-argument
-    def mocked_requests_get(*args, **kwargs):
-        if args[0] == "https://127.0.0.1:8080/api/v2/k8scluster":
-            return MockResponse(
-                json_data={
-                    "_links": {"self": {"href": "/api/v2/k8scluster"}},
-                    "_embedded": {
-                        "k8sclusters": [
-                            {
-                                "_links": {
-                                    "self": {"href": "/api/v2/k8scluster/20"}
-                                },
-                                "label": {
-                                    "name": "def",
-                                    "description": "my cluster",
-                                },
-                                "k8s_version": "1.17.0",
-                                "pod_network_range": "10.192.0.0/12",
-                                "service_network_range": "10.96.0.0/12",
-                                "pod_dns_domain": "cluster.local",
-                                "created_by_user_id": "/api/v1/user/5",
-                                "created_by_user_name": "admin",
-                                "created_time": 1588260014,
-                                "k8shosts_config": [
-                                    {
-                                        "node": "/api/v2/worker/k8shost/4",
-                                        "role": "worker",
-                                    },
-                                    {
-                                        "node": "/api/v2/worker/k8shost/5",
-                                        "role": "master",
-                                    },
-                                ],
-                                "status": "ready",
-                                "status_message": "really ready",
-                                "api_endpoint_access": "api:1234",
-                                "dashboard_endpoint_access": "dashboard:1234",
-                                "admin_kube_config": "xyz==",
-                                "dashboard_token": "abc==",
-                                "persistent_storage": {"nimble_csi": False},
-                            }
-                        ]
-                    },
-                },
-                status_code=200,
-                headers={},
-            )
-        raise RuntimeError("Unhandle GET request: " + args[0])
-
     def setUp(self):
         file_data = dedent(
             """[default]
@@ -141,18 +82,31 @@ def setUp(self):
         self.cli = cli
         self.cli.HPECP_CONFIG_FILE = self.tmpFile.name
 
+        self.saved_stdout = sys.stdout
+        self.out = StringIO()
+        sys.stdout = self.out
+
     def tearDown(self):
         self.tmpFile.close()
+        sys.stdout = self.saved_stdout
 
-    def test_autocomplete_bash(self):
+    def test_config_file_missing(self):
 
-        hpecp = self.cli.CLI()
-        hpecp.autocomplete.bash()
+        with self.assertRaises(SystemExit) as cm:
+            self.cli.HPECP_CONFIG_FILE = "this_file_should_not_exist"
+            self.cli.get_client()
 
-    # TODO move this to tests/library/k8s_cluster_test.py
-    @patch("requests.post", side_effect=mocked_requests_post)
-    @patch("requests.get", side_effect=mocked_requests_get)
-    def test_k8scluster_list(self, mock_post, mock_get):
+        self.assertEqual(cm.exception.code, 1)
+
+        self.assertEqual(
+            self.out.getvalue(),
+            "Could not find configuration file 'this_file_should_not_exist'\n",
+        )
+
+    def test_autocomplete_bash(self):
 
-        hpecp = self.cli.CLI()
-        hpecp.k8scluster.list()
+        try:
+            hpecp = self.cli.CLI()
+            hpecp.autocomplete.bash()
+        except Exception:
+            self.fail("Unexpected exception.")