fix(logging): output http response

Signed-off-by: Chris Snow <[email protected]>

Author: snowch

docs/source/cli_overview.rst

@@ -63,7 +63,7 @@ See https://docs.python.org/3.7/howto/logging.html for much more info on logging
 Logging Configuration
 ---------------------
 
-To change logging configuration, e.g. to log to a file set the environment variable `HPECP_LOG_CONFIG_FILE` and provide a configuration file.
+To change logging configuration, e.g. to log to a file, set the environment variable `HPECP_LOG_CONFIG_FILE` and provide a configuration file.
 
 Example: `HPECP_LOG_CONFIG_FILE=~/.hpecp_logging.conf`:
 

hpecp/client.py

@@ -658,14 +658,21 @@ def _request(
             else:
                 response_info = ""
 
-            if response.status_code == 403:
-                # This is expected for some method calls so do not log as an
-                # error
+            def log_response():
                 self.log.debug(
-                    "{} : {} {} REQ: {}".format(
-                        description, http_method, url, json.dumps(data)
+                    "RES: {} : {} {} : {} {}".format(
+                        description,
+                        http_method,
+                        url,
+                        response.status_code,
+                        response_info,
                     )
                 )
+
+            if response.status_code == 403:
+                # This is expected for some method calls so do not log as an
+                # error
+                log_response()
                 raise APIForbiddenException(
                     message=response_info,
                     request_method=http_method,
@@ -675,11 +682,7 @@ def _request(
             if response.status_code == 404:
                 # This is expected for some method calls so do not log as an
                 # error
-                self.log.debug(
-                    "{} : {} {} REQ: {}".format(
-                        description, http_method, url, json.dumps(data)
-                    )
-                )
+                log_response()
                 raise APIItemNotFoundException(
                     message=response_info,
                     request_method=http_method,
@@ -689,23 +692,15 @@ def _request(
             if response.status_code == 409:
                 # This is expected for some method calls so do not log as an
                 # error
-                self.log.debug(
-                    "{} : {} {} REQ: {}".format(
-                        description, http_method, url, json.dumps(data)
-                    )
-                )
+                log_response()
                 raise APIItemConflictException(
                     message=response_info,
                     request_method=http_method,
                     request_url=url,
                     request_data=json.dumps(data),
                 )
             else:
-                self.log.debug(
-                    "{} : {} {} REQ: {}".format(
-                        description, http_method, url, json.dumps(data)
-                    )
-                )
+                log_response()
                 raise APIUnknownException(
                     message=str(re),  # get the exception message
                     request_method=http_method,