Fix the issue with crash on process restore #6997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a case when the app process is killed and restored by Android OS. When the app is restored it tries to restore all fragments. But the navController is not getting restored and it contains single back stack entry, which is mainFragment. So if user was in the page like TokenBalanceFragment or TransactionInfoFragment, those fragments are restored. Since they do not get expected data, they call `navController.popBackStack()`. It results in popping off the single mainFragment of the back stack. And the MainFragment tries to create TransactionsViewModel using the mainFragment back stack entry. But the nav controller back stack is empty. That is why it crashes app. Fixed issue by ensuring that those fragments closes themselves if needed.
rafaelekol
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6843
There is a case when the app process is killed and restored by Android OS. When the app is restored it tries to restore all fragments. But the navController is not getting restored and it contains single back stack entry, which is mainFragment.
So if user was in the page like TokenBalanceFragment or TransactionInfoFragment, those fragments are restored. Since they do not get expected data, they call
navController.popBackStack(). It results in popping off the single mainFragment of the back stack. And the MainFragment tries to create TransactionsViewModel using the mainFragment back stack entry. But the nav controller back stack is empty. That is why it crashes app.Fixed issue by ensuring that those fragments closes themselves if needed.