Update Recipe Robot to support/replicate SparkleUpdateInfoProvider
current version detection capabilities
#207
Labels
SparkleUpdateInfoProvider
current version detection capabilities
#207
Is your feature request related to a problem? Please describe.
Recipe Robot's logic for discovering 'version' from a Sparkle appcast url does not behave the same as
SparkleUpdateInfoProvider
and consequently adds a redundantVersioner
processor to[AppName].download.recipe
Describe the solution you'd like
I may be mistaken, but RR is only looking for app version info in the appcast xml
enclosure
, and when it's not found it downloads the most recent url, and adds aVersioner
processor to discover the app version. Version discovery was updated inSparkleUpdateInfoProvider
with this change: autopkg/autopkg#841. Versions found outside ofenclosure
are respected and now used.Adding the same behavior to RR as was added to
SparkleUpdateInfoProvider
in autopkg/autopkg#841 would allow RR to pull the same version info asSparkleUpdateInfoProvider
and should stop RR from creating redundantVersioner
processor steps in[AppName].download.recipe
.If the updated logic in RR does not find a version anywhere in the appcast xml it should not create a recipe using the
SparkleUpdateInfoProvider
as any appcast xml with no version should fail to download. As it did when theSparkleUpdateInfoProvider
was only looking inenclosure
for version info... autopkg/autopkg#839Describe alternatives you've considered
Keeping the logic that adds a
Versioner
processor to a Sparkle download recipe. However, if theVersioner
processor is required,SparkleUpdateInfoProvider
should already fail to download the app in the first place.Additional context
Just thanks for your continued work on RR! It's a huge help maintaining my autpkg/munki.
The text was updated successfully, but these errors were encountered: