Skip to content

Fix show_items endpoint in example app #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastapi_permissions/example.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ async def show_items(
user=Depends(get_current_user),
):
available_permissions = {
index: list_permissions(user.principals, get_item(index))
index: list_permissions(get_active_principals(user), get_item(index))
for index in fake_items_db
}
return [
Expand Down
37 changes: 37 additions & 0 deletions tests/test_example_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,43 @@ def test_app_get_me(username, client):
[
("/items/", "bob", True),
("/items/", "alice", True),
],
)
def test_app_items_permissions(url, username, granted, client):
""" test urls protected by principals, permissions and acls """
response = get_with_user(url, username, client)
data = response.json()
assert data == [
{
"items": {
"1": {
"name": "Stilton",
"owner": "bob"
},
"2": {
"name": "Danish Blue",
"owner": "alice"
}
},
"available_permissions": {
"1": {
"use": username == "bob",
"view": True
},
"2": {
"use": True,
"view": True
}
}
}
]

assert response.status_code == 200 if granted else 403


@pytest.mark.parametrize(
"url, username, granted",
[
("/item/add", "bob", False),
("/item/add", "alice", True),
("/item/1", "bob", True),
Expand Down