Skip to content

Commit 027727a

Browse files
committed
Merge remote-tracking branch 'origin/main' into dockerci
2 parents 8a75448 + e55c8e2 commit 027727a

File tree

8 files changed

+584
-605
lines changed

8 files changed

+584
-605
lines changed

.github/workflows/tests.yml

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
test_chapter_15_advanced_forms,
3232
test_chapter_16_javascript,
3333
test_chapter_18_spiking_custom_auth,
34+
test_chapter_19_mocking,
3435
unit-test
3536
]
3637

chapter_15_advanced_forms.asciidoc

+8-2
Original file line numberDiff line numberDiff line change
@@ -843,12 +843,18 @@ use Django instead, it seems like we need to bring back our custom
843843
<1> We give `.was-validated` to the `<form>`
844844
<2> We provide an `<input>` and the most important custom setting will be its
845845
`class`. As you can see, we can use conditionals even for providing
846-
additional `class` -es.
846+
additional `class` -es.footnote:[
847+
We've split the form tag across three lines so it fits nicely in the book.
848+
If you've not seen that before, it may look a little weird to you,
849+
but I promise it is valid HTML.
850+
You don't have to use it if you don't like it though. :)]
851+
847852
<3> If you try to just simply display `form.errors.text` you'll see it ends up
848853
as a list item in an unordered list. To avoid that, let's just
849854
select `form.errors.text.0`.
850855
851-
NOTE: Another fliip-flop! We spent most of the last chapter switching from handcrafted html
856+
NOTE: Another fliip-flop!
857+
We spent most of the last chapter switching from handcrafted html
852858
to having our form autogenerated by django, and now we're switching back.
853859
It's a little frustrating, and I could have gone back and changed the book's text to avoid the back+forth,
854860
but I prefer to show software development as it really is.

chapter_18_spiking_custom_auth.asciidoc

+1
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,7 @@ form for the login email:
842842
class="form-control"
843843
placeholder="[email protected]"
844844
/>
845+
{% csrf_token %}
845846
</div>
846847
</form>
847848
</div>

0 commit comments

Comments
 (0)