HHH-19229 Faster checks in ReflectHelper

Author: obourgain

hibernate-core/src/main/java/org/hibernate/internal/util/ReflectHelper.java

@@ -15,6 +15,7 @@
 import java.lang.reflect.TypeVariable;
 import java.lang.reflect.WildcardType;
 import java.util.Locale;
+import java.util.Objects;
 import java.util.function.Supplier;
 
 import org.hibernate.AssertionFailure;
@@ -573,16 +574,14 @@ public static void verifyNoIsVariantExists(
 			Method getMethod,
 			String stemName) {
 		// verify that the Class<?> does not also define a method with the same stem name with 'is'
-		try {
-			final Method isMethod = containerClass.getDeclaredMethod( "is" + stemName );
-			if ( !Modifier.isStatic( isMethod.getModifiers() ) && isMethod.getAnnotation( Transient.class ) == null ) {
-				// No such method should throw the caught exception.  So if we get here, there was
-				// such a method.
-				checkGetAndIsVariants( containerClass, propertyName, getMethod, isMethod );
+		for ( Method declaredMethod : containerClass.getDeclaredMethods() ) {
+			if ( declaredMethod.getParameterCount() == 0
+				 && !Modifier.isStatic( declaredMethod.getModifiers() )
+				 && Objects.equals( declaredMethod.getName(), "is" + stemName )
+				 && declaredMethod.getAnnotation( Transient.class ) == null ) {
+				checkGetAndIsVariants( containerClass, propertyName, getMethod, declaredMethod );
 			}
 		}
-		catch (NoSuchMethodException ignore) {
-		}
 	}
 
 
@@ -613,17 +612,14 @@ public static void verifyNoGetVariantExists(
 			Method isMethod,
 			String stemName) {
 		// verify that the Class<?> does not also define a method with the same stem name with 'is'
-		try {
-			final Method getMethod = containerClass.getDeclaredMethod( "get" + stemName );
-			// No such method should throw the caught exception.  So if we get here, there was
-			// such a method.
-			if ( !Modifier.isStatic( getMethod.getModifiers() )
-					&& getMethod.getAnnotation( Transient.class ) == null ) {
-				checkGetAndIsVariants( containerClass, propertyName, getMethod, isMethod );
+		for ( Method declaredMethod : containerClass.getDeclaredMethods() ) {
+			if ( declaredMethod.getParameterCount() == 0
+				 && !Modifier.isStatic( declaredMethod.getModifiers() )
+				 && Objects.equals( declaredMethod.getName(), "get" + stemName )
+				 && declaredMethod.getAnnotation( Transient.class ) == null ) {
+				checkGetAndIsVariants( containerClass, propertyName, declaredMethod, isMethod );
 			}
 		}
-		catch (NoSuchMethodException ignore) {
-		}
 	}
 
 	public static Method getterMethodOrNull(Class<?> containerJavaType, String propertyName) {