Refacor "manage_options"

Author: J. David Ibanez

LanguageManager.py

@@ -22,14 +22,15 @@
 
 # Import from Zope
 from App.class_init import InitializeClass
+from App.Management import Tabs
 from AccessControl import ClassSecurityInfo
 
 # Import from Localizer
 from LocalFiles import LocalDTMLFile
-from utils import lang_negotiator
+from utils import lang_negotiator, _
 
 
-class LanguageManager(object):
+class LanguageManager(Tabs):
     """ """
 
     security = ClassSecurityInfo()
@@ -153,9 +154,19 @@ def get_selected_language(self, **kw):
     # ZMI
     ########################################################################
     manage_options = (
-        {'label': u'Languages', 'action': 'manage_languages',
-         'help': ('Localizer', 'LM_languages.stx')},
-    )
+        {'action': 'manage_languages', 'label': u'Languages',
+         'help': ('Localizer', 'LM_languages.stx')},)
+
+
+    def filtered_manage_options(self, REQUEST=None):
+        options = Tabs.filtered_manage_options(self, REQUEST=REQUEST)
+        r = []
+        for option in options:
+            option = option.copy()
+            option['label'] = _(option['label'])
+            r.append(option)
+
+        return r
 
 
     security.declareProtected('View management screens', 'manage_languages')

LocalContent.py

@@ -72,25 +72,15 @@ class LocalContent(CatalogAware, LocalPropertyManager, PropertyManager,
     body = LocalAttribute('body')
 
 
-    def manage_options(self):
-        """ """
-        options = \
-            LocalPropertyManager.manage_options \
-            + PropertyManager.manage_options[:1] \
-            + ({'action': 'manage_import', 'label': u'Import',
-                'help': ('Localizer', 'MC_importExport.stx')},
-               {'action': 'manage_export', 'label': u'Export',
-                'help': ('Localizer', 'MC_importExport.stx')}) \
-            + PropertyManager.manage_options[1:] \
-            + SimpleItem.manage_options
-
-        r = []
-        for option in options:
-            option = option.copy()
-            option['label'] = _(option['label'])
-            r.append(option)
-
-        return r
+    manage_options = \
+        LocalPropertyManager.manage_options \
+        + PropertyManager.manage_options[:1] \
+        + ({'action': 'manage_import', 'label': u'Import',
+            'help': ('Localizer', 'MC_importExport.stx')},
+           {'action': 'manage_export', 'label': u'Export',
+            'help': ('Localizer', 'MC_importExport.stx')}) \
+        + PropertyManager.manage_options[1:] \
+        + SimpleItem.manage_options
 
 
     def __init__(self, id, sourcelang, languages):

LocalFolder.py

@@ -57,21 +57,11 @@ def __init__(self, id, title, languages):
         self._local_attributes = ()
 
 
-    def manage_options(self):
-        """ """
-        options = Folder.manage_options[:1] \
-                  + ({'label': u'Attributes',
-                    'action': 'manage_attributes'},) \
-                  + LanguageManager.manage_options \
-                  + Folder.manage_options[1:]
-
-        r = []
-        for option in options:
-            option = option.copy()
-            option['label'] = _(option['label'])
-            r.append(option)
-
-        return r
+    manage_options = \
+        Folder.manage_options[:1] \
+        + ({'action': 'manage_attributes', 'label': u'Attributes'},) \
+        + LanguageManager.manage_options \
+        + Folder.manage_options[1:]
 
 
     # Manage attributes

Localizer.py

@@ -31,7 +31,7 @@
 # Import Localizer modules
 from LocalFiles import LocalDTMLFile
 from MessageCatalog import MessageCatalog
-from utils import lang_negotiator, needs_upgrade, _
+from utils import lang_negotiator, needs_upgrade
 from LanguageManager import LanguageManager
 
 
@@ -65,24 +65,14 @@ class Localizer(LanguageManager, Folder):
 
     security = ClassSecurityInfo()
 
-    def manage_options(self):
-        """The manage options are defined here so they can be translated"""
-        options = (
-            {'action': 'manage_upgradeForm',
-             'filter': needs_upgrade,
-             'label': u'Upgrade',
-             'help': ('Localizer', 'Localizer_upgrade.stx')},
-            Folder.manage_options[0]) \
-            + LanguageManager.manage_options \
-            + Folder.manage_options[1:]
-
-        r = []
-        for option in options:
-            option = option.copy()
-            option['label'] = _(option['label'])
-            r.append(option)
-
-        return r
+    manage_options = (
+        {'action': 'manage_upgradeForm',
+         'filter': needs_upgrade,
+         'label': u'Upgrade',
+         'help': ('Localizer', 'Localizer_upgrade.stx')},
+        Folder.manage_options[0]) \
+        + LanguageManager.manage_options \
+        + Folder.manage_options[1:]
 
 
     def __init__(self, title, languages):

MessageCatalog.py

@@ -308,26 +308,16 @@ def manage_beforeDelete(self, item, container):
     #######################################################################
     # Management screens
     #######################################################################
-    def manage_options(self):
-        """ """
-        options = (
-            {'label': u'Messages', 'action': 'manage_messages',
-             'help': ('Localizer', 'MC_messages.stx')},
-            {'label': u'Properties', 'action': 'manage_propertiesForm'},
-            {'label': u'Import', 'action': 'manage_Import_form',
-             'help': ('Localizer', 'MC_importExport.stx')},
-            {'label': u'Export', 'action': 'manage_Export_form',
-             'help': ('Localizer', 'MC_importExport.stx')}) \
-            + LanguageManager.manage_options \
-            + SimpleItem.manage_options
-
-        r = []
-        for option in options:
-            option = option.copy()
-            option['label'] = _(option['label'])
-            r.append(option)
-
-        return r
+    manage_options = (
+        {'label': u'Messages', 'action': 'manage_messages',
+         'help': ('Localizer', 'MC_messages.stx')},
+        {'label': u'Properties', 'action': 'manage_propertiesForm'},
+        {'label': u'Import', 'action': 'manage_Import_form',
+         'help': ('Localizer', 'MC_importExport.stx')},
+        {'label': u'Export', 'action': 'manage_Export_form',
+         'help': ('Localizer', 'MC_importExport.stx')}) \
+        + LanguageManager.manage_options \
+        + SimpleItem.manage_options
 
 
     #######################################################################