Building the example (clang/test/Frontend/plugin-syntax-print-tokens.cpp)

[chelini]

Hi, I am trying to use the syntax plugin but I am hitting the following error:

[2882/2883] Running lit suite /home/lchelini/scratch/llvm-project-csp-orig/clang/test/Frontend
llvm-lit: /home/lchelini/scratch/llvm-project-csp-orig/llvm/utils/lit/lit/llvm/config.py:342: note: using clang: /home/lchelini/scratch/llvm-project-csp-orig/build/bin/clang
FAIL: Clang :: Frontend/plugin-syntax-print-tokens.cpp (40 of 131)
******************** TEST 'Clang :: Frontend/plugin-syntax-print-tokens.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/lchelini/scratch/llvm-project-csp-orig/build/bin/clang -std=c++11 -fplugin=/home/lchelini/scratch/llvm-project-csp-orig/build/./lib/PrintTokensSyntax.so -emit-llvm -S /home/lchelini/scratch/llvm-project-csp-orig/clang/test/Frontend/plugin-syntax-print-tokens.cpp -o - | /home/lchelini/scratch/llvm-project-csp-orig/build/bin/FileCheck /home/lchelini/scratch/llvm-project-csp-orig/clang/test/Frontend/plugin-syntax-print-tokens.cpp
--
Exit Code: 2

Command Output (stderr):
--
: CommandLine Error: Option 'non-global-value-max-name-size' registered more than once!
fatal error: error in backend: inconsistency in registered CommandLine options
clang-10: error: clang frontend command failed with exit code 70 (use -v to see invocation)
clang version 10.0.0 (https://github.com/hfinkel/llvm-project-csp.git e6b6a5711708403ac889086e6609b02905327545)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/lchelini/scratch/llvm-project-csp-orig/build/bin
clang-10: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
clang-10: note: diagnostic msg: Error generating preprocessed source(s).
FileCheck error: '-' is empty.
FileCheck command line:  /home/lchelini/scratch/llvm-project-csp-orig/build/bin/FileCheck /home/lchelini/scratch/llvm-project-csp-orig/clang/test/Frontend/plugin-syntax-print-tokens.cpp

--

********************

Testing Time: 17.22s
********************
Failing Tests (1):
    Clang :: Frontend/plugin-syntax-print-tokens.cpp

  Expected Passes    : 125
  Unsupported Tests  : 5
  Unexpected Failures: 1

Any idea why? Thanks a lot!

[chelini]

Able to compile using BUILD_SHARED_LIBS=ON (see: https://bugs.llvm.org/show_bug.cgi?id=22952)

[tpops]

Hi I am sorry for the late reply. Do you still have this issue ?

[chelini]

Hi @tpops sorry for the latency. I managed to find a way to solve it, but I have now a follow-up question. Currently, the plugin makes use of llvm::registry which requires the registered subclass (SyntaxHandler and subclasses of it) to have a default constructor, while it may be nice to pass extra parameters to the constructor. Do you know a solution for this?
Thanks a lot!

See:

llvm-project-csp/llvm/include/llvm/Support/Registry.h

Line 112 in 9044b79

/// 1. The registered subclass has a default constructor.

[tpops]

Hi @chelini,

Sorry for the late reply.

The structure of the registry is such that the objects of registered plugins are instantiated at run time.

When you register a class for syntax plugin, the compiler starts the plugin during parsing.

SyntaxPlugin *plug1 = new YourClass();

calls are then made to your overriden derived methods in your class.

This uses a template to create this initialization and does not support adding constructor parameters.

Maybe in the future there might be some way to support this