fix: figcaption only works within figure

stevenjoezhang · stevenjoezhang · commit 7b1e95731114 · 2024-04-02T01:19:40.000+08:00
diff --git a/lib/renderer.js b/lib/renderer.js
@@ -137,8 +137,8 @@ class Renderer extends MarkedRenderer {
     if (lazyload) out += ' loading="lazy"';
 
     out += '>';
-    if (figcaption) {
-      if (text) out += `<figcaption aria-hidden="true">${text}</figcaption>`;
+    if (figcaption && text) {
+      return `<figure>${out}<figcaption aria-hidden="true">${text}</figcaption></figure>`;
     }
     return out;
   }

Original file line number	Diff line number	Diff line change
`@@ -137,8 +137,8 @@ class Renderer extends MarkedRenderer {`
`137`	`137`	`if (lazyload) out += ' loading="lazy"';`
`138`	`138`
`139`	`139`	`out += '>';`
`140`		`- if (figcaption) {`
`141`		- if (text) out += `<figcaption aria-hidden="true">${text}</figcaption>`;
	`140`	`+ if (figcaption && text) {`
	`141`	+ return `<figure>${out}<figcaption aria-hidden="true">${text}</figcaption></figure>`;
`142`	`142`	`}`
`143`	`143`	`return out;`
`144`	`144`	`}`