Considered pprofServer as nil and simplified test path for HTTP requests

Author: Sherry Yao

cmdutil/debug/debug.go

@@ -125,16 +125,18 @@ func NewPProfServer(config PProfServerConfig, l logrus.FieldLogger) *PProfServer
 //
 // It implements oklog group's runFn.
 func (s *PProfServer) Run() error {
+	if s.pprofServer == nil {
+		return fmt.Errorf("pprofServer is nil")
+	}
+
 	s.logger.WithFields(logrus.Fields{
 		"at":      "binding",
 		"service": "pprof",
 		"addr":    s.addr,
 	}).Info()
 
-	if s.pprofServer != nil {
-		if err := s.pprofServer.ListenAndServe(); err != nil && err != http.ErrServerClosed {
-			return err
-		}
+	if err := s.pprofServer.ListenAndServe(); err != nil && err != http.ErrServerClosed {
+		return err
 	}
 
 	<-s.done

cmdutil/debug/debug_test.go

@@ -63,36 +63,27 @@ func TestNewPProfServer(t *testing.T) {
 			}
 			runtime.SetMutexProfileFraction(tt.expectedMutexFraction) // Reset to the expected value
 
-			urls := []string{
-				"http://" + server.addr + "/debug/pprof/",
-				"http://" + server.addr + "/debug/pprof/heap",
-				"http://" + server.addr + "/debug/pprof/goroutine",
-				"http://" + server.addr + "/debug/pprof/threadcreate",
-				"http://" + server.addr + "/debug/pprof/block",
-				"http://" + server.addr + "/debug/pprof/mutex",
-			}
-
-			// Perform HTTP GET requests to ensure the server is running and all handlers respond correctly
+			// Perform HTTP GET request to the root path
+			url := "http://" + server.addr + "/debug/pprof/"
 			client := &http.Client{}
-			for _, url := range urls {
-				t.Run("GET "+url, func(t *testing.T) {
-					req, err := http.NewRequest("GET", url, nil)
-					if err != nil {
-						t.Errorf("http.NewRequest(%s) error = %v", url, err)
-					}
-
-					resp, err := client.Do(req)
-					if err != nil {
-						t.Errorf("http.Client.Do() error = %v", err)
-					}
-
-					if resp.StatusCode != http.StatusOK {
-						t.Errorf("http.Client.Do() status = %v, want %v", resp.StatusCode, http.StatusOK)
-					}
-
-					resp.Body.Close()
-				})
-			}
+
+			t.Run("GET "+url, func(t *testing.T) {
+				req, err := http.NewRequest("GET", url, nil)
+				if err != nil {
+					t.Errorf("http.NewRequest(%s) error = %v", url, err)
+				}
+
+				resp, err := client.Do(req)
+				if err != nil {
+					t.Errorf("http.Client.Do() error = %v", err)
+				}
+
+				if resp.StatusCode != http.StatusOK {
+					t.Errorf("http.Client.Do() status = %v, want %v", resp.StatusCode, http.StatusOK)
+				}
+
+				resp.Body.Close()
+			})
 
 			// Stop the server
 			server.Stop(nil)